Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x] Update error message when lucene max document limit is breached #11382

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rayshrey
Copy link
Contributor

Description

Auto backport for #11312 failed
Raising a manual backport PR for the same.

Related Issue

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>

---------

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change b4891c4

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for b4891c4: SUCCESS

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1c6494) 71.09% compared to head (b4891c4) 71.09%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #11382   +/-   ##
=========================================
  Coverage     71.09%   71.09%           
+ Complexity    59140    59131    -9     
=========================================
  Files          4869     4869           
  Lines        278725   278725           
  Branches      40847    40847           
=========================================
+ Hits         198164   198169    +5     
+ Misses        63761    63722   -39     
- Partials      16800    16834   +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit b2770de into opensearch-project:2.x Nov 29, 2023
@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants