Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flaky test SimpleBlocksIT.testAddBlockWhileDeletingIndices #11492

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ankitkala
Copy link
Member

Description

Fix for flaky test SimpleBlocksIT.testAddBlockWhileDeletingIndices

Adds a retry logic for delete index call incase the call fails due to ProcessClusterEventTimeoutException

Related Issues

Resolves #2472

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. bug Something isn't working flaky-test Random test failure that succeeds on second run labels Dec 6, 2023
@ankitkala ankitkala marked this pull request as ready for review December 6, 2023 16:28
@ankitkala ankitkala added the backport 2.x Backport to 2.x branch label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Compatibility status:

Checks if related components are compatible with change 01844a5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Dec 6, 2023

❕ Gradle check result for 01844a5: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (f7f3500) 71.37% compared to head (01844a5) 71.39%.
Report is 2 commits behind head on main.

Files Patch % Lines
...rch/pipeline/common/CollapseResponseProcessor.java 71.42% 7 Missing and 5 partials ⚠️
...ch/pipeline/common/helpers/SearchResponseUtil.java 69.69% 8 Missing and 2 partials ⚠️
...search/core/common/io/stream/BytesStreamInput.java 40.00% 7 Missing and 2 partials ⚠️
...earch/search/pipeline/common/SearchRequestMap.java 80.00% 6 Missing and 3 partials ⚠️
...search/pipeline/common/ScriptRequestProcessor.java 40.00% 6 Missing ⚠️
...ch/pipeline/common/OversampleRequestProcessor.java 73.68% 3 Missing and 2 partials ⚠️
...pipeline/common/TruncateHitsResponseProcessor.java 84.61% 2 Missing and 2 partials ⚠️
...rg/opensearch/search/pipeline/common/BasicMap.java 90.90% 2 Missing ⚠️
...eline/common/SearchPipelineCommonModulePlugin.java 0.00% 1 Missing ⚠️
...h/search/pipeline/common/helpers/ContextUtils.java 75.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11492      +/-   ##
============================================
+ Coverage     71.37%   71.39%   +0.02%     
- Complexity    59113    59132      +19     
============================================
  Files          4893     4903      +10     
  Lines        277831   277983     +152     
  Branches      40367    40382      +15     
============================================
+ Hits         198288   198465     +177     
- Misses        63042    63056      +14     
+ Partials      16501    16462      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit a3c7952 into opensearch-project:main Dec 6, 2023
118 of 119 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2023
…11492)

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit a3c7952)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Dec 7, 2023
…11492) (#11496)

(cherry picked from commit a3c7952)

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pensearch-project#11492)

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] o.o.blocks.SimpleBlocksIT.testAddBlockWhileDeletingIndices
3 participants