-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute flaky testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness #11767
Conversation
❌ Gradle check result for 69d30c1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 5b53974 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git] |
...er/src/internalClusterTest/java/org/opensearch/cluster/allocation/AwarenessAllocationIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
❕ Gradle check result for 5b53974: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11767 +/- ##
============================================
- Coverage 71.27% 71.23% -0.05%
- Complexity 59176 59191 +15
============================================
Files 4909 4911 +2
Lines 278429 278666 +237
Branches 40460 40528 +68
============================================
+ Hits 198443 198500 +57
- Misses 63528 63647 +119
- Partials 16458 16519 +61 ☔ View full report in Codecov by Sentry. |
…pensearch-project#11767) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…pensearch-project#11767) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This change mutes the flaky test - testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness.
The test fails frequently because OpenSearch in a way follows greedy approach while allocating shards and doesn't compute the optimal allocation for all the shards that needs to be allocated. This approach based on certain filters and rules tries to control nodes where shards are assigned.
The unassigned shards causing test failure is due to the same above reason where a node where the shard was supposed to be assigned created a conflict with the awareness allocation decider. Hence, it is stuck in a state, waiting for space to allocate the unassigned shard because it cannot assign it to the only node with space. This also seemed more likely to happen in this particular test case because it is creating a 15 nodes cluster and over 120 shards which increases the probability of landing up in such a case. A smaller cluster with lesser shards would be less likely to land up in such a case.
Disabling this test till we fix up the allocation algorithm which can be taken up as part of #10554
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#7401 #3603
Check List
[ ] New functionality includes testing.[ ] All tests pass[] New functionality has been documented.[ ] New functionality has javadoc added[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)[] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.