Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Single line comments can end in newline or EOF. Fixes #11815 #11834

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8192488 from #11816.

* Single line comments can end in newline or EOF. Fixes #11815

Signed-off-by: camerondurham <u64.cam@gmail.com>

* Re-add license to autogen parser files

Signed-off-by: camerondurham <u64.cam@gmail.com>

* Remove noise from changelog

Signed-off-by: Cameron Durham <u64.cam@gmail.com>

* Accept single-line comments until newline char

Signed-off-by: Cameron Durham <u64.cam@gmail.com>

---------

Signed-off-by: camerondurham <u64.cam@gmail.com>
Signed-off-by: Cameron Durham <u64.cam@gmail.com>
(cherry picked from commit 8192488)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acef38e) 71.06% compared to head (5c8aa91) 70.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11834      +/-   ##
============================================
- Coverage     71.06%   70.95%   -0.12%     
+ Complexity    59316    59290      -26     
============================================
  Files          4889     4889              
  Lines        279821   279821              
  Branches      41034    41034              
============================================
- Hits         198865   198554     -311     
- Misses        64033    64408     +375     
+ Partials      16923    16859      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5c8aa91

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 10, 2024
Copy link
Contributor

❌ Gradle check result for 5c8aa91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 10, 2024

❌ Gradle check result for 5c8aa91: FAILURE

#11032
#10673

Copy link
Contributor

❕ Gradle check result for 5c8aa91: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit a41646e into 2.x Jan 10, 2024
82 checks passed
@github-actions github-actions bot deleted the backport/backport-11816-to-2.x branch January 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant