-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in API annotation check message #11836
Conversation
❌ Gradle check result for c395a6b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change d055341 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
c395a6b
to
96c6221
Compare
- Fixing some internal comments as well Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
96c6221
to
d055341
Compare
❌ Gradle check result for 96c6221: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11836 +/- ##
=========================================
Coverage 71.41% 71.41%
- Complexity 59292 59320 +28
=========================================
Files 4919 4919
Lines 278912 278912
Branches 40543 40543
=========================================
+ Hits 199191 199196 +5
+ Misses 63171 63111 -60
- Partials 16550 16605 +55 ☔ View full report in Codecov by Sentry. |
Thanks @lukas-vlcek ! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11836-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 feeb595be5c998efca4d11d65ea6a3d00cea17dd
# Push it to GitHub
git push --set-upstream origin backport/backport-11836-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@lukas-vlcek could you please backport to |
- Fixing some internal comments as well Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit feeb595)
- Fixing some internal comments as well Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
- Fixing some internal comments as well Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Spotted a typo in API annotation check message
Fix typo in API annotation check message.
(Fixing some internal comments as well.)
Related Issues
N/A
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.