Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshot Interop] Add changes for overriding remote store and replic… #11868

Merged
merged 4 commits into from
Apr 11, 2024
Merged

[Snapshot Interop] Add changes for overriding remote store and replic… #11868

merged 4 commits into from
Apr 11, 2024

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Jan 12, 2024 •
edited
Loading

…ation settings during snapshot restore.

Description

As part of this PR:

  • Overriding remote store and replication strategy related index settings during snapshot restore.
  • Not Allowing users to override/ignore remote store related settings during restore.

Refer #11669 for more details.

Related Issues

Resolves #11669

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 28aaf7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 7d1d795

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

@harishbhakuni harishbhakuni marked this pull request as ready for review January 22, 2024 17:42
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f04da49: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Copy link
Member

Changes LGTM. Please fix the build.

@harishbhakuni
Copy link
Contributor Author

Failing test org.opensearch.upgrades.RefreshVersionInClusterStateIT.testRefresh is flaky: #11933

ashking94
ashking94 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2bcea9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2bcea9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2bcea9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna added v2.14.0 and removed v2.13.0 Issues and PRs related to version 2.13.0 labels Apr 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

❕ Gradle check result for d8f29cd: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Harish Bhakuni added 4 commits April 10, 2024 06:50
[Snapshot Interop] Add changes for overriding remote store and replic…
4faa67e 
…ation settings during snapshot restore.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
[Snapshot Interop] Add changes to not allow user to override remote s…
9d7268c 
…tore index settings during snapshot restore.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments.
e82195d 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Address PR Comments.
7d1d795 
Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7d1d795: SUCCESS

@gbbafna gbbafna merged commit 4fc3a02 into opensearch-project:main Apr 11, 2024
29 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Apr 11, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@github-actions
[Snapshot Interop] Add changes for overriding remote store and replic… (
cc6fa50 
#11868)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
(cherry picked from commit 4fc3a02)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 11, 2024
Merged
gbbafna pushed a commit that referenced this pull request Apr 11, 2024
@opensearch-trigger-bot @github-actions
[Snapshot Interop] Add changes for overriding remote store and replic… (
0ed8e6c 
#11868) (#13152)

(cherry picked from commit 4fc3a02)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@harishbhakuni @shiv0408
[Snapshot Interop] Add changes for overriding remote store and replic… (
e01c4c7 
opensearch-project#11868)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@ashking94 ashking94 ashking94 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@harishbhakuni harishbhakuni

Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.14.0
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remote Store] Override remote store and replication strategy settings during snapshot restore.
5 participants
@harishbhakuni @sachinpkale @ashking94 @gbbafna @rramachand21