Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11988

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Backport 2.x] Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11988

merged 1 commit into from
Jan 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 48fdb4f from #11968.

@github-actions
Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression…
2be4c6c 
…, introduced in JDK-21.0.2 (#11968)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 48fdb4f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2be4c6c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git]

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2be4c6c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2be4c6c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 23, 2024

❌ Gradle check result for 2be4c6c: FAILURE

#8638
#8946
#8947
#10006
#6090
#11993

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2be4c6c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 23, 2024

❌ Gradle check result for 2be4c6c: null

#8638
#8946
#8947
#10755
#10983

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2be4c6c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 23, 2024

❌ Gradle check result for 2be4c6c: null

#8638
#8946
#8947
#10755
#11997

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 2be4c6c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c40fcff) 71.12% compared to head (2be4c6c) 71.17%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ch/common/util/concurrent/OpenSearchExecutors.java 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11988      +/-   ##
============================================
+ Coverage     71.12%   71.17%   +0.05%     
- Complexity    59361    59367       +6     
============================================
  Files          4891     4891              
  Lines        279940   279944       +4     
  Branches      41055    41055              
============================================
+ Hits         199099   199256     +157     
+ Misses        63957    63827     -130     
+ Partials      16884    16861      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit 7365414 into 2.x Jan 23, 2024
81 of 82 checks passed
@github-actions github-actions bot deleted the backport/backport-11968-to-2.x branch January 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Test roadmap format
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @kotwanikunal