[DOCS] Remove the changes made for doc tests for default distribution ("oss-docs" branch)

[tlfeng]

Issue #, if available:
#88

Description of changes:
The PR requests merging the code into oss-docs branch.

There was a commit elastic/elasticsearch@7354928 that made some special adjustments for running the docs test for default distribution, the PR removes those special changes, as well as the "build_flavor" attribute. (Part of the "build_flavor" removal is done in PR #137)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[tlfeng]

The changes in this PR can not be tested, as there is some unexpected errors probably after the removal of "non-oss".

[2021-02-22T21:56:11,805][ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [node-0] uncaught exception in thread [main]
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalArgumentException: unknown setting [script.painless.regex.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:173) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:160) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:127) ~[elasticsearch-cli-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
Caused by: java.lang.IllegalArgumentException: unknown setting [script.painless.regex.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:544) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:489) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:460) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:431) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.SettingsModule.<init>(SettingsModule.java:149) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.node.Node.<init>(Node.java:405) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.node.Node.<init>(Node.java:289) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:227) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:227) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:393) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:169) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	... 6 more
	Suppressed: java.lang.IllegalArgumentException: unknown setting [reindex.remote.whitelist] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

[setiah]

The changes in this PR can not be tested, as there is some unexpected errors probably after the removal of "non-oss".

[2021-02-22T21:56:11,805][ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [node-0] uncaught exception in thread [main]
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalArgumentException: unknown setting [script.painless.regex.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:173) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:160) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:127) ~[elasticsearch-cli-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
Caused by: java.lang.IllegalArgumentException: unknown setting [script.painless.regex.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:544) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:489) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:460) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:431) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.common.settings.SettingsModule.<init>(SettingsModule.java:149) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.node.Node.<init>(Node.java:405) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.node.Node.<init>(Node.java:289) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:227) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:227) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:393) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:169) ~[elasticsearch-7.10.3-SNAPSHOT.jar:7.10.3-SNAPSHOT]
	... 6 more
	Suppressed: java.lang.IllegalArgumentException: unknown setting [reindex.remote.whitelist] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

The commit mentioned seems pretty old. Was this test working before our commits? Do we know the commit after which it started breaking

[tlfeng]

Hi @setiah,
As a reply to the above comment:
The error was caused by the commit in yesterday fd36020, because the docs test can be ran after I reverted the change. It totally block the running for :docs:integTest.
I rebased the "oss-docs" branch onto "main" in last evening, so the commit is in the "oss-docs" branch.

Besides, after I reverted the commit, I found something wrong with the test for "cat nodeattrs" after running :docs:integTest, so the PR needs further change. [Update: this was solved]

[tlfeng]

Currently there are the 4 test failures in "docs:check" for the PR, and they are caused by the removal of "build_flavor" field, this are expected to be solved after merging the changes of removing "build_flavor" in "main" branch.

    DocsClientYamlTestSuiteIT. test {yaml=plugins/discovery-azure-classic/line_339}
    DocsClientYamlTestSuiteIT. test {yaml=reference/cluster/nodes-info/line_200}
    DocsClientYamlTestSuiteIT. test {yaml=reference/cluster/nodes-info/line_270}
    DocsClientYamlTestSuiteIT. test {yaml=reference/setup/install/check-running/line_7}

java.lang.AssertionError: Failure at [reference/setup/install/check-running:15]: $body didn't match expected value:
                         $body: 
                    cluster_name: same [integTest]
                    cluster_uuid: same [AvFt13JITleTrzqpYSNAdA]
                            name: same [node-0]
                         tagline: same [You Know, for Search]
                         version: 
                        build_date: same [2021-02-23T18:07:22.346556Z]
                        build_hash: same [3f14ce151f98b2ca0ea9fc90cd8d232a30f5af60]
                    build_snapshot: same [true]
                        build_type: same [tar]
                    lucene_version: same [8.7.0]
    minimum_index_compatibility_version: same [6.0.0-beta1]
    minimum_wire_compatibility_version: same [6.8.0]
                            number: same [7.10.3-SNAPSHOT]
                      build_flavor: unexpected but found [default]

[peterzhuamazon]

Can one of the admins verify this patch?

[tlfeng]

The issue in my above comment is addressed in PR #137, I will merge the change into the feature branch of my fork repo.

[tlfeng]

Testing result:

./gradlew :docs:check
Starting a Gradle Daemon (subsequent builds will be faster)

=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 6.6.1
  OS Info               : Linux 5.4.0-1038-aws (amd64)
  JDK Version           : 14 (JDK)
  JAVA_HOME             : /usr/lib/jvm/java-14-openjdk-amd64
  Random Testing Seed   : C0335A5D73A6FBF6
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 8m 15s
267 actionable tasks: 202 executed, 65 up-to-date

[setiah]

LGTM. Thanks Tianli!