Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added New Fast DateTime parser implementation for RFC3339 Datetime format #12107

Merged

Conversation

CaptainDredge
Copy link
Contributor

@CaptainDredge CaptainDredge commented Jan 31, 2024

Description

Backporting #11465

Related Issues

Resolves #8361

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Jan 31, 2024
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Compatibility status:

Checks if related components are compatible with change 0c5d794

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 44aa53e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
(cherry picked from commit 829215c)
Copy link
Contributor

❕ Gradle check result for 0c5d794: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (ff820ed) 71.10% compared to head (0c5d794) 71.07%.

Files Patch % Lines
...ommon/time/RFC3339CompatibleDateTimeFormatter.java 72.62% 28 Missing and 21 partials ⚠️
...earch/common/time/OpenSearchDateTimeFormatter.java 52.38% 10 Missing ⚠️
.../org/opensearch/common/time/JavaDateFormatter.java 92.85% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12107      +/-   ##
============================================
- Coverage     71.10%   71.07%   -0.04%     
- Complexity    59419    59445      +26     
============================================
  Files          4892     4894       +2     
  Lines        280005   280242     +237     
  Branches      41073    41107      +34     
============================================
+ Hits         199093   199173      +80     
- Misses        64031    64212     +181     
+ Partials      16881    16857      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaptainDredge
Copy link
Contributor Author

❕ Gradle check result for 0c5d794: UNSTABLE
TEST FAILURES:
1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test: #6090

@CaptainDredge
Copy link
Contributor Author

@reta can you please review this backport PR?

@reta reta merged commit 7e3c080 into opensearch-project:2.x Jan 31, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

2 participants