Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable concurrent search path for composite aggregations. #12380

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented Feb 19, 2024

Description

Backport of #12375

Related Issues

#12331

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
      - [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    - [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…etails see: opensearch-project#12331

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 21007d8

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 21007d8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator Author

sohami commented Feb 19, 2024

❌ Gradle check result for 21007d8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

test suite timeout:

[org.opensearch.search.fetch.subphase.highlight.HighlighterSearchIT.testPostingsHighlighterQueryStringWithinFilteredQuery {p0={"search.concurrent_segment_search.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/33932/testReport/junit/org.opensearch.search.fetch.subphase.highlight/HighlighterSearchIT/testPostingsHighlighterQueryStringWithinFilteredQuery__p0___search_concurrent_segment_search_enabled___false___/)
[org.opensearch.search.fetch.subphase.highlight.HighlighterSearchIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/33932/testReport/junit/org.opensearch.search.fetch.subphase.highlight/HighlighterSearchIT/classMethod/)

Copy link
Contributor

❕ Gradle check result for 21007d8: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d26b0be) 71.16% compared to head (21007d8) 71.14%.

Files Patch % Lines
.../bucket/composite/CompositeAggregationFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.12   #12380      +/-   ##
============================================
- Coverage     71.16%   71.14%   -0.03%     
+ Complexity    59903    59860      -43     
============================================
  Files          4939     4939              
  Lines        281814   281814              
  Branches      41272    41272              
============================================
- Hits         200565   200490      -75     
- Misses        64320    64420     +100     
+ Partials      16929    16904      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 2c355ce into opensearch-project:2.12 Feb 20, 2024
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants