Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add support for Running Parameterized Remote Store Enabled Integration Tests #12487

Conversation

Rishikesh1159
Copy link
Member

@Rishikesh1159 Rishikesh1159 commented Feb 28, 2024

Description

This PR introduces the support for running parameterized Remote Store enabled Integ Tests. This PR follows similar approach done for segment replication here in #11773.

With with PR we can run any Integration tests twice.
-> One time with remote store enabled.
-> Another with remotes store disabled.

This way instead of creating a new Integration Test specific to remote store everytime, we can simply extend ParameterizedStaticSettingsOpenSearchIntegTestCase and run exsting Integ Test with remote store enabled.

This Parameterization should only be used for Integ Tests that are critical for remote-store behaviour. If test is not critical to remote-store behaviour then we use randomization to increase test coverage

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sts.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for 2c1b67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 28, 2024

Compatibility status:

Checks if related components are compatible with change 3668b18

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 6892406: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Copy link
Contributor

✅ Gradle check result for 3668b18: SUCCESS

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (7921175) to head (3668b18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12487      +/-   ##
============================================
+ Coverage     71.37%   71.43%   +0.05%     
+ Complexity    59891    59883       -8     
============================================
  Files          4972     4972              
  Lines        281783   281797      +14     
  Branches      40910    40913       +3     
============================================
+ Hits         201136   201294     +158     
+ Misses        63977    63758     -219     
- Partials      16670    16745      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poojita-Raj Poojita-Raj added the backport 2.x Backport to 2.x branch label Feb 28, 2024
@Rishikesh1159 Rishikesh1159 merged commit 8ce3687 into opensearch-project:main Mar 13, 2024
45 of 61 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 13, 2024
…bled Integration Tests (#12487)

* Add support for parameterized remote-store testing for Integration Tests.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Rename variable names.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
(cherry picked from commit 8ce3687)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@rramachand21 rramachand21 added the Storage:Resiliency Issues and PRs related to the storage resiliency label Mar 14, 2024
andrross pushed a commit that referenced this pull request Mar 15, 2024
…bled Integration Tests (#12487) (#12647)

* Add support for parameterized remote-store testing for Integration Tests.



* Rename variable names.



---------



(cherry picked from commit 8ce3687)

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…bled Integration Tests (opensearch-project#12487)

* Add support for parameterized remote-store testing for Integration Tests.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Rename variable names.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…bled Integration Tests (opensearch-project#12487)

* Add support for parameterized remote-store testing for Integration Tests.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Rename variable names.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Resiliency Issues and PRs related to the storage resiliency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants