-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allocation decider for mixed cluster #12505
Add allocation decider for mixed cluster #12505
Conversation
❌ Gradle check result for bfa399c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 20f5207 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 9fc1b0f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9fc1b0f
to
b68ec88
Compare
❌ Gradle check result for b68ec88: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b68ec88
to
87f2ce7
Compare
❌ Gradle check result for 87f2ce7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
87f2ce7
to
3de0a79
Compare
❌ Gradle check result for 3de0a79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave 1 pass . Will review IT and UT later .
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...rc/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for b98b0bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
b98b0bd
to
689f2f6
Compare
❌ Gradle check result for 689f2f6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...va/org/opensearch/cluster/routing/allocation/RemoteStoreMigrationAllocationDeciderTests.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/cluster/routing/allocation/RemoteStoreMigrationAllocationDeciderTests.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/cluster/routing/allocation/RemoteStoreMigrationAllocationDeciderTests.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/cluster/routing/allocation/RemoteStoreMigrationAllocationDeciderTests.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/cluster/routing/allocation/RemoteStoreMigrationAllocationDeciderTests.java
Outdated
Show resolved
Hide resolved
...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
...nternalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationAllocationIT.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 194aba3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
194aba3
to
20f5207
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12505 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.05%
- Complexity 59978 60089 +111
============================================
Files 4985 4990 +5
Lines 282275 282625 +350
Branches 40946 40996 +50
============================================
+ Hits 201603 202000 +397
+ Misses 63999 63849 -150
- Partials 16673 16776 +103 ☔ View full report in Codecov by Sentry. |
opensearch-project#12505) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
opensearch-project#12505) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
opensearch-project#12505) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
A new allocation decider for migration of document replication clusters to remote store backed clusters
STRICT
compatibility mode, the decision is always YESREMOTE_STORE
migration direction:Related Issues
As part of #12518
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.