Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest-api-spec test search.highlight/30_max_analyzed_offset[5] #12548

Closed
wants to merge 1 commit into from

Conversation

saimedhi
Copy link
Contributor

@saimedhi saimedhi commented Mar 6, 2024

Description

Fix rest-api-spec test search.highlight/30_max_analyzed_offset[5] to prevent https://github.com/opensearch-project/opensearch-py/actions/runs/8178214405/job/22361632385#step:10:2054

Related Issues

opensearch-project/opensearch-py#686
https://github.com/opensearch-project/opensearch-py/actions/runs/8178214405/job/22361632385#step:10:2054

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Compatibility status:

Checks if related components are compatible with change 4bd360a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Mar 6, 2024

❌ Gradle check result for 4bd360a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Mar 7, 2024

@saimedhi what's the story here?

@saimedhi
Copy link
Contributor Author

saimedhi commented Mar 7, 2024

@saimedhi what's the story here?

I attempted to resolve a failing YAML test in opensearch-py, but I found that the same test is passing in the Rust client. So, I think the fix should be applied to the opensearch-py test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants