-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Force merge API supports performing only on primary shards (#11269) #12609
[Backport 2.x] Force merge API supports performing only on primary shards (#11269) #12609
Conversation
…h-project#11269) * Force merge API supports performing on primary shards only Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix typo Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify skip version Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add version check and more tests Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Format code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify supported version and add more test Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Change the supported version to 3.0.0 Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add test case in SegmentReplicationIT Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Optimize the test code Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit e6eec36)
Compatibility status:Checks if related components are compatible with change 7d1c255 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 51d9bb3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for a3465d6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for 1340aa8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for e9b194d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Failures are related to: #12593 |
❕ Gradle check result for e9b194d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #12609 +/- ##
============================================
- Coverage 71.28% 71.15% -0.13%
+ Complexity 60145 60084 -61
============================================
Files 4957 4957
Lines 282799 282834 +35
Branches 41409 41414 +5
============================================
- Hits 201591 201264 -327
- Misses 64189 64577 +388
+ Partials 17019 16993 -26 ☔ View full report in Codecov by Sentry. |
@gaobinlong It looks like below test is flaky. Can you check this please ?
|
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
...api-spec/src/main/resources/rest-api-spec/test/indices.forcemerge/20_wait_for_completion.yml
Outdated
Show resolved
Hide resolved
...api-spec/src/main/resources/rest-api-spec/test/indices.forcemerge/20_wait_for_completion.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for a25b43d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 83fb554: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The failed test seems not related to this PR, and there's an issue tracking it but seems we haven't resolved it yet. |
❌ Gradle check result for 7d1c255: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 7d1c255: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Known issue: #11993 |
@gaobinlong We will need a forward port to change the version checks in main branch. Also probably we can update the yml tests as done in this PR. Can you also create a documentation issue or PR for this new option ? |
Thanks, I'll create a following PR for the main branch, and both of the related document issue and PR have been created yet. |
Description
Backport #11269 to 2.x.
Related Issues
#8021
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.