-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky SettingTests Tests #12706
Fix Flaky SettingTests Tests #12706
Conversation
❌ Gradle check result for 1339f9e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 643ddba Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 74be731: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kkmr TBR, thank you. |
❌ Gradle check result for b096eec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
org.opensearch.telemetry.metrics.TelemetryMetricsEnabledSanityIT.testObservableGauge |
❌ Gradle check result for b096eec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kkewwei I think you need to rebase, you might be behind main |
Signed-off-by: kkewwei <kkewwei@163.com>
❌ Gradle check result for afdc5d3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
org.opensearch.telemetry.metrics.TelemetryMetricsEnabledSanityIT.testObservableGauge #12717 |
no test failed. |
Looks transient. @kkewwei unfortunately these require manual pushing still - a maintainer will do it, but if you see one of these before, force push a noop update ( |
❌ Gradle check result for afdc5d3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12706 +/- ##
============================================
+ Coverage 71.42% 71.43% +0.01%
- Complexity 59978 60246 +268
============================================
Files 4985 5011 +26
Lines 282275 283665 +1390
Branches 40946 41117 +171
============================================
+ Hits 201603 202646 +1043
- Misses 63999 64160 +161
- Partials 16673 16859 +186 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kkewwei <kkewwei@163.com>
❌ Gradle check result for 643ddba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 643ddba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 643ddba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
* Fix Flaky SettingTests Tests Signed-off-by: kkewwei <kkewwei@163.com> * add the comment to unit test Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kkewwei@163.com> Co-authored-by: kkewwei <kkewwei@163.com> (cherry picked from commit 839ee4c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix Flaky SettingTests Tests * add the comment to unit test --------- (cherry picked from commit 839ee4c) Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: kkewwei <kkewwei@163.com>
* Fix Flaky SettingTests Tests Signed-off-by: kkewwei <kkewwei@163.com> * add the comment to unit test Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kkewwei@163.com> Co-authored-by: kkewwei <kkewwei@163.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
* Fix Flaky SettingTests Tests Signed-off-by: kkewwei <kkewwei@163.com> * add the comment to unit test Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kkewwei@163.com> Co-authored-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei kkewwei@163.com
Description
org.opensearch.common.settings.SettingTests.testMemorySizeWithFallbackValue is flaky
Related Issues
Resolves #12705
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.