Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky SettingTests Tests #12706

Closed
wants to merge 2 commits into from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Mar 17, 2024

Signed-off-by: kkewwei kkewwei@163.com

Description

org.opensearch.common.settings.SettingTests.testMemorySizeWithFallbackValue is flaky

Related Issues

Resolves #12705

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 1339f9e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 17, 2024

Compatibility status:

Checks if related components are compatible with change 643ddba

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 74be731: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Mar 21, 2024

@kkmr TBR, thank you.

Copy link
Contributor

❌ Gradle check result for b096eec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Mar 21, 2024

❌ Gradle check result for b096eec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.telemetry.metrics.TelemetryMetricsEnabledSanityIT.testObservableGauge

#12717

Copy link
Contributor

❌ Gradle check result for b096eec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Mar 21, 2024

@kkewwei I think you need to rebase, you might be behind main

Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

❌ Gradle check result for afdc5d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Mar 22, 2024

❌ Gradle check result for b096eec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.telemetry.metrics.TelemetryMetricsEnabledSanityIT.testObservableGauge #12717

@kkewwei
Copy link
Contributor Author

kkewwei commented Mar 22, 2024

❌ Gradle check result for afdc5d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

no test failed.

@dblock
Copy link
Member

dblock commented Mar 22, 2024

Task :qa:wildfly:composeUp FAILED

Looks transient.

@kkewwei unfortunately these require manual pushing still - a maintainer will do it, but if you see one of these before, force push a noop update (git commit --amend ; git push -f ...) to re-kick the CI yourself.

Copy link
Contributor

❌ Gradle check result for afdc5d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for afdc5d3: SUCCESS

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (b15cb0c) to head (afdc5d3).
Report is 82 commits behind head on main.

❗ Current head afdc5d3 differs from pull request most recent head 643ddba. Consider uploading reports for the commit 643ddba to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12706      +/-   ##
============================================
+ Coverage     71.42%   71.43%   +0.01%     
- Complexity    59978    60246     +268     
============================================
  Files          4985     5011      +26     
  Lines        282275   283665    +1390     
  Branches      40946    41117     +171     
============================================
+ Hits         201603   202646    +1043     
- Misses        63999    64160     +161     
- Partials      16673    16859     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

❌ Gradle check result for 643ddba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 643ddba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 643ddba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock dblock mentioned this pull request Mar 26, 2024
8 tasks
reta pushed a commit that referenced this pull request Mar 26, 2024
* Fix Flaky SettingTests Tests

Signed-off-by: kkewwei <kkewwei@163.com>

* add the comment to unit test

Signed-off-by: kkewwei <kkewwei@163.com>

---------

Signed-off-by: kkewwei <kkewwei@163.com>
Co-authored-by: kkewwei <kkewwei@163.com>
@kkewwei kkewwei closed this Mar 27, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
* Fix Flaky SettingTests Tests

Signed-off-by: kkewwei <kkewwei@163.com>

* add the comment to unit test

Signed-off-by: kkewwei <kkewwei@163.com>

---------

Signed-off-by: kkewwei <kkewwei@163.com>
Co-authored-by: kkewwei <kkewwei@163.com>
(cherry picked from commit 839ee4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Mar 27, 2024
* Fix Flaky SettingTests Tests



* add the comment to unit test



---------



(cherry picked from commit 839ee4c)

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kkewwei <kkewwei@163.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Fix Flaky SettingTests Tests

Signed-off-by: kkewwei <kkewwei@163.com>

* add the comment to unit test

Signed-off-by: kkewwei <kkewwei@163.com>

---------

Signed-off-by: kkewwei <kkewwei@163.com>
Co-authored-by: kkewwei <kkewwei@163.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
* Fix Flaky SettingTests Tests

Signed-off-by: kkewwei <kkewwei@163.com>

* add the comment to unit test

Signed-off-by: kkewwei <kkewwei@163.com>

---------

Signed-off-by: kkewwei <kkewwei@163.com>
Co-authored-by: kkewwei <kkewwei@163.com>
@kkewwei kkewwei deleted the issue-12705 branch June 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.common.settings.SettingTests.testMemorySizeWithFallbackValue is flaky
3 participants