-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cluster default remote store path type during snapshot restore #12753
Use cluster default remote store path type during snapshot restore #12753
Conversation
Compatibility status:Checks if related components are compatible with change 45aaf5b Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for 3f2262e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12753 +/- ##
============================================
- Coverage 71.42% 71.35% -0.07%
- Complexity 59978 60153 +175
============================================
Files 4985 4999 +14
Lines 282275 283045 +770
Branches 40946 41030 +84
============================================
+ Hits 201603 201958 +355
- Misses 63999 64377 +378
- Partials 16673 16710 +37 ☔ View full report in Codecov by Sentry. |
Ran the |
…t restore Signed-off-by: Ashish Singh <ssashish@amazon.com>
3f2262e
to
08cb85c
Compare
❕ Gradle check result for f8f6806: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
f8f6806
to
45aaf5b
Compare
Flaky test - #11299 |
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Show resolved
Hide resolved
tagging @gbbafna, @linuxpi, @sachinpkale for review. |
0510c5b
into
opensearch-project:main
…pensearch-project#12753) * Use cluster default remote store path type as fallback during snapshot restore --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…pensearch-project#12753) * Use cluster default remote store path type as fallback during snapshot restore --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
…12753) (#13401) * Use cluster default remote store path type as fallback during snapshot restore --------- (cherry picked from commit 0510c5b) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR is a sub task of feature request #12567 and being tracked in meta issue - #12589.
In the prior PR #12607, we have introduced remote store path type in the customData field in IndexMetadata. We associate the path during index creation. However, there are certain cases where the association needs to be handled manually. They are as follows -
cluster.remote_store.index.path.prefix.type
to benefit from the optimised prefix. In absence of this PR, we will continue to use non-optimised prefix.In this PR, we are handling 1st case.
Related Issues
Resolves #12730
Check List
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.