Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported version for the wait_for_completion parameter in open&clone&shrink&split APIs #12819

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Mar 21, 2024

Description

In the PR #6434, we've added wait_for_completion parameter for open&clone&shrink&split&forcemerge APIs, after the PR was merged and backported to 2.x branch, we need to update the supported version in the yaml test file to ensure that change can be covered by yaml test.

The supported version in the yaml test file of forcemerge API has been changed by other PR, this PR only change the version for the remaining APIs.

The wait_for_completion parameter is not serialized/deserialized, so no java code change.

Backport and changelog is not needed.

Related Issues

#6228

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n&clone&shrink&split APIs

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 89a6c77

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 89a6c77: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.37%. Comparing base (b15cb0c) to head (89a6c77).
Report is 68 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12819      +/-   ##
============================================
- Coverage     71.42%   71.37%   -0.05%     
- Complexity    59978    60239     +261     
============================================
  Files          4985     5011      +26     
  Lines        282275   283638    +1363     
  Branches      40946    41116     +170     
============================================
+ Hits         201603   202457     +854     
- Misses        63999    64391     +392     
- Partials      16673    16790     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong
Copy link
Collaborator Author

❕ Gradle check result for 89a6c77: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Known issue: #1561.

@reta
Copy link
Collaborator

reta commented Mar 21, 2024

Thanks @gaobinlong !

@reta reta merged commit 53c0ce3 into opensearch-project:main Mar 21, 2024
65 of 129 checks passed
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…n&clone&shrink&split APIs (opensearch-project#12819)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants