Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed API visibility annotations for public APIs #12920

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Mar 26, 2024

Description

#12872 adds missed API visibility annotations for public APIs and enable the check at the build time. Since #12822 had clean build and was raised before the 12872 PR, after merge the build has failed. In this PR, we add the missed annotations.

Related Issues

None

Check List

  • [ ] New functionality includes testing.
    • All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change af429fa

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for af429fa: SUCCESS

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.32%. Comparing base (b15cb0c) to head (af429fa).
Report is 92 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12920      +/-   ##
============================================
- Coverage     71.42%   71.32%   -0.10%     
- Complexity    59978    60193     +215     
============================================
  Files          4985     5015      +30     
  Lines        282275   283799    +1524     
  Branches      40946    41130     +184     
============================================
+ Hits         201603   202429     +826     
- Misses        63999    64531     +532     
- Partials      16673    16839     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit f6d6fd3 into opensearch-project:main Mar 26, 2024
108 of 111 checks passed
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Apr 23, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ject#12920)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Apr 26, 2024
sachinpkale pushed a commit that referenced this pull request Apr 26, 2024
…2822 #12920  (#13405)

* Refactor remote store flow to support any path type (#12822)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add missed API visibility annotations for public APIs (#12920)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants