-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement mark() in class FilterStreamInput #13098
Conversation
bea846c
to
d0ad0d9
Compare
❌ Gradle check result for 1a87940: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for bea846c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
libs/core/src/main/java/org/opensearch/core/common/io/stream/FilterStreamInput.java
Show resolved
Hide resolved
❌ Gradle check result for 1d10350: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for d0ad0d9: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13098 +/- ##
============================================
+ Coverage 71.42% 71.43% +0.01%
- Complexity 59978 60454 +476
============================================
Files 4985 5026 +41
Lines 282275 284528 +2253
Branches 40946 41215 +269
============================================
+ Hits 201603 203260 +1657
- Misses 63999 64449 +450
- Partials 16673 16819 +146 ☔ View full report in Codecov by Sentry. |
libs/core/src/test/java/org/opensearch/core/common/io/stream/FilterStreamInputTests.java
Show resolved
Hide resolved
Please add CHANGELOG entry |
❌ Gradle check result for 34f9f36: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
❌ Gradle check result for 943b988: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for c8a0961: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
testConcurrentDecommissionAction #12197 |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13098-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8779e5297a502d4bfc1c0b199813babb7bc62726
# Push it to GitHub
git push --set-upstream origin backport/backport-13098-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@kkewwei could you please backport to |
* implement mark() in class FilterStreamInput Signed-off-by: kkewwei <kkewwei@163.com> * implement markSupported() in class FilterStreamInput Signed-off-by: kkewwei <kkewwei@163.com> * add CHANGELOG Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: kkewwei kkewwei@163.com
Description
Implement mark() in class FilterStreamInput
Related Issues
Resolves #13096
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.