-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer remote replicas for primary promotion during migration #13136
Prefer remote replicas for primary promotion during migration #13136
Conversation
Compatibility status:Checks if related components are compatible with change f1ed40d Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13136 +/- ##
============================================
+ Coverage 71.42% 71.54% +0.12%
- Complexity 59978 60714 +736
============================================
Files 4985 5039 +54
Lines 282275 285446 +3171
Branches 40946 41342 +396
============================================
+ Hits 201603 204234 +2631
- Misses 63999 64297 +298
- Partials 16673 16915 +242 ☔ View full report in Codecov by Sentry. |
ef77db6
to
de62d59
Compare
❌ Gradle check result for de62d59: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
de62d59
to
f1ed40d
Compare
server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/cluster/routing/allocation/FailedShardsRoutingTests.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/routing/RoutingNodes.java
Outdated
Show resolved
Hide resolved
f1ed40d
to
fa31864
Compare
❕ Gradle check result for fa31864: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
fa31864
to
3a25b08
Compare
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> (cherry picked from commit efa06fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…arch-project#13136) Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com> (cherry picked from commit efa06fe)
Description
MIXED
compatibility mode andREMOTE_STORE
migration direction), we aim to continuously move forward.metadata
is used to identify migration conditionsactiveReplicaOnRemoteNode
makes use of thefailedShard
's id, to obtain migrated replica copies and randomly returns oneRelated Issues
Resolves #13135
Check List
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.