-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write shard level metadata blob when snapshotting searchable snapshot indexes #13190
Write shard level metadata blob when snapshotting searchable snapshot indexes #13190
Conversation
Btw, I have no good idea when reading old snapshot. Maybe when we getting shard snapshot, we can check the snapshot index settings after SnapshotMissingException is thrown, if target index is remote snapshot, then return a empty snapshot status. Any thoughts? |
@andrross you may be interested in this :) |
❌ Gradle check result for 6045092: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 6045092 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git] |
This PR is stalled because it has been open for 30 days with no activity. |
9899f6a
to
6763bb8
Compare
❌ Gradle check result for 9899f6a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6763bb8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6763bb8
to
55475a6
Compare
@andrross @kotwanikunal would you please have a look when you have a chance and merge this if it is possible |
❌ Gradle check result for 55475a6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
55475a6
to
d1b94bc
Compare
❌ Gradle check result for d1b94bc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13190-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 568c193dd817b76b2f0ca4647bc4e01908db709d
# Push it to GitHub
git push --set-upstream origin backport/backport-13190-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
… indexes (opensearch-project#13190) * fix snapshot status Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> * Fix spotless violations Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 568c193)
… indexes (#13190) (#14492) * fix snapshot status Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> * Fix spotless violations Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 568c193) Co-authored-by: panguixin <panguixin@bytedance.com>
… indexes (opensearch-project#13190) * fix snapshot status Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> * Fix spotless violations Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
… indexes (opensearch-project#13190) (opensearch-project#14492) * fix snapshot status Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> * Fix spotless violations Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 568c193) Co-authored-by: panguixin <panguixin@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
… indexes (opensearch-project#13190) * fix snapshot status Signed-off-by: panguixin <panguixin@bytedance.com> * add change log Signed-off-by: panguixin <panguixin@bytedance.com> * Fix spotless violations Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
Description
In #7247, we only snapshot the index metadata if the target index is searchable snapshot, so we don't create shard level snapshot metadata under shard blob container (ie.
snap-{uuid}.dat
blob). But this metadata blob needs to be loaded when getting snapshot status or cloning snapshot. Currently, following exception will be thrown if we call snapshot status api and target snapshot contains searchable snapshot.We can write the shard level snapshot metadata to resolve this issue.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.