-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote path settings to RemoteStoreSettings class #13225
Add remote path settings to RemoteStoreSettings class #13225
Conversation
Changes look good. Branch has multiple conflicts with |
@sachinpkale adding the reverted changes back as part of #13251. Once that is merged back, we should be good with the conflict part. |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Detect breaking changes is failing due to refactoring of some methods that are present in only main branch as of now and yet to be released.
We should ignore the "Detect breaking failure" changes here. cc @sachinpkale |
ed21977
to
61a0532
Compare
❕ Gradle check result for 61a0532: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13225 +/- ##
============================================
+ Coverage 71.42% 71.45% +0.03%
- Complexity 59978 60679 +701
============================================
Files 4985 5040 +55
Lines 282275 285456 +3181
Branches 40946 41338 +392
============================================
+ Hits 201603 203975 +2372
- Misses 63999 64662 +663
- Partials 16673 16819 +146 ☔ View full report in Codecov by Sentry. |
|
Thanks for adding these details. |
…3225) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 9c35a84) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 9c35a84) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This is a follow up PR from #13155 (comment). In this PR, we have moved 2 settings -
cluster.remote_store.index.path.type
andcluster.remote_store.index.path.hash_algorithm
to the RemoteStoreSettings class.Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.