Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Handle OpenSearchRejectedExecutionException while retrying refresh #13301

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Apr 19, 2024

Description

  • Currently, while scehduling retry of refesh for remote backed index, OpenSearchRejectedExecutionException is thrown if the executor is shutdown. This could happen when the node is shutting down.
  • This results in flakiness of tests as observed in #10762 and #11993

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sachin Kale <kalsac@amazon.com>
@sachinpkale
Copy link
Member Author

Running the tests in local for 1000+ times to check if the flakiness is gone.

Copy link
Contributor

❌ Gradle check result for 521a3f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 172aed8: SUCCESS

Copy link
Contributor

@ltaragi ltaragi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

✅ Gradle check result for 521a3f0: SUCCESS

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.32%. Comparing base (b15cb0c) to head (521a3f0).
Report is 203 commits behind head on main.

Files Patch % Lines
...ndex/shard/ReleasableRetryableRefreshListener.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13301      +/-   ##
============================================
- Coverage     71.42%   71.32%   -0.10%     
- Complexity    59978    60573     +595     
============================================
  Files          4985     5039      +54     
  Lines        282275   285436    +3161     
  Branches      40946    41338     +392     
============================================
+ Hits         201603   203600    +1997     
- Misses        63999    64933     +934     
- Partials      16673    16903     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit ae49fd2 into opensearch-project:main Apr 23, 2024
27 of 29 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Apr 23, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2024
…13301)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit ae49fd2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gbbafna gbbafna deleted the flaky-10762 branch April 23, 2024 12:14
gbbafna pushed a commit that referenced this pull request Apr 23, 2024
…13301) (#13349)

(cherry picked from commit ae49fd2)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants