-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add X-Opaque-Id to search request metadata for query insights #13374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
April 25, 2024 02:03
This was referenced Apr 25, 2024
❌ Gradle check result for 62b17bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/search/labels/rules/DefaultUserInfoLabelingRule.java
Outdated
Show resolved
Hide resolved
ansjcy
commented
May 1, 2024
server/src/main/java/org/opensearch/search/labels/SearchRequestLabelingListener.java
Outdated
Show resolved
Hide resolved
5 tasks
ansjcy
changed the title
[DRAFT] POC for customized and rule-based labeling for search queries
Customized and rule-based labeling for search queries
May 20, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13374-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d3cf43e7f06d2011c931cf829439e9fba97f18d
# Push it to GitHub
git push --set-upstream origin backport/backport-13374-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
ansjcy
added a commit
to ansjcy/OpenSearch
that referenced
this pull request
Jun 7, 2024
…arch-project#13374) --------- Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 9d3cf43) Signed-off-by: Chenyang Ji <cyji@amazon.com>
3 tasks
jed326
pushed a commit
that referenced
this pull request
Jun 7, 2024
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…arch-project#13374) --------- Signed-off-by: Chenyang Ji <cyji@amazon.com>
This was referenced Jun 13, 2024
3 tasks
This was referenced Jun 27, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…arch-project#13374) (opensearch-project#14078) --------- (cherry picked from commit 9d3cf43) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…arch-project#13374) --------- Signed-off-by: Chenyang Ji <cyji@amazon.com>
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
backport-failed
v2.15.0
Issues and PRs related to version 2.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customized and labeling for search queries in top n queries
A simple demo test of the changes:
Steps
X-Opaque-Id
my_tag
is there in the top n queries resultsDeprecated for the alternative approach: A simple demo test of the changes:
Steps
my_tenant_tag
and default labels injected by the default rules are there in the top n queries resultsDetailed Results
Related Issues
#13341
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.