Add unit test of multipler orders for multiple terms aggregation. #13400

Zhikai-VM · 2024-04-26T04:23:59Z

Description

I added unit tests to verify the multiple orders in the multiple terms aggregation.

Related Issues

Resolves #13375

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-04-26T05:11:14Z

❕ Gradle check result for f09ee2d: UNSTABLE

TEST FAILURES:

      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-04-26T05:12:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (b15cb0c) to head (15e994e).
Report is 228 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13400      +/-   ##
============================================
+ Coverage     71.42%   71.61%   +0.19%     
- Complexity    59978    60863     +885     
============================================
  Files          4985     5045      +60     
  Lines        282275   286080    +3805     
  Branches      40946    41432     +486     
============================================
+ Hits         201603   204889    +3286     
- Misses        63999    64280     +281     
- Partials      16673    16911     +238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/370_multi_terms.yml

dblock

Great stuff.

You need to amend/sign your commits with DCO, -s, please?

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/370_multi_terms.yml

dblock · 2024-04-26T20:18:43Z

Since these tests pass, make the changes in the comments as you suggested in #13375 and maybe open a documentation PR?

github-actions · 2024-04-27T02:37:17Z

✅ Gradle check result for a3a1f23: SUCCESS

github-actions · 2024-04-27T02:40:36Z

✅ Gradle check result for f5a9520: SUCCESS

github-actions · 2024-04-27T02:52:11Z

✅ Gradle check result for 5257b82: SUCCESS

Zhikai-VM · 2024-04-27T04:28:27Z

Since these tests pass, make the changes in the comments as you suggested in #13375 and maybe open a documentation PR?

I have updated the comments in 'MultiTermsAggregationBuilder.java'.

github-actions · 2024-04-27T05:14:47Z

✅ Gradle check result for bd340cf: SUCCESS

Zhikai-VM · 2024-04-27T13:26:06Z

Create a doc issue for this: opensearch-project/documentation-website#7037

dblock · 2024-04-27T13:51:00Z

Can you please rebase to get CI to pass? We fixed these errors in #13412, but need to make sure there's nothing else broken. Thanks!

1. test case for multiple orders 2. test case for multiple orders and size Signed-off-by: Zhikai Chen <snoopy_czk@126.com>

Signed-off-by: Zhikai Chen <snoopy_czk@126.com>

Zhikai-VM · 2024-04-27T14:02:44Z

Can you please rebase to get CI to pass? We fixed these errors in #13412, but need to make sure there's nothing else broken. Thanks!

Done.

github-actions · 2024-04-27T14:54:37Z

✅ Gradle check result for 15e994e: SUCCESS

Zhikai-VM · 2024-04-27T22:46:32Z

Great stuff.

You need to amend/sign your commits with DCO, -s, please?

Done.

Zhikai-VM · 2024-04-28T01:28:59Z

Hi @dblock , could you please kindly let me know what should I do next? (I have signed the commits, but still shows "1 change requested")

dblock · 2024-04-29T17:37:41Z

Hi @dblock , could you please kindly let me know what should I do next? (I have signed the commits, but still shows "1 change requested")

It's me! I needed to re-review and hit approve ;)

dblock · 2024-04-29T17:38:25Z

Thanks for contributing @Zhikai-VM! Hope you can pickup something else ;)

…3400) * Add unit test cases for multiple terms aggregation: 1. test case for multiple orders 2. test case for multiple orders and size Signed-off-by: Zhikai Chen <snoopy_czk@126.com> * Update the comments. Signed-off-by: Zhikai Chen <snoopy_czk@126.com> --------- Signed-off-by: Zhikai Chen <snoopy_czk@126.com> (cherry picked from commit 4ee984f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…3400) (#13450) * Add unit test cases for multiple terms aggregation: 1. test case for multiple orders 2. test case for multiple orders and size * Update the comments. --------- (cherry picked from commit 4ee984f) Signed-off-by: Zhikai Chen <snoopy_czk@126.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Zhikai-VM · 2024-04-29T23:33:01Z

Thanks for contributing @Zhikai-VM! Hope you can pickup something else ;)

Thanks for your help!

ankyhe · 2024-05-06T07:21:51Z

@dblock We want to revise the official document also. Could you answer this comment: opensearch-project/documentation-website#7039 (comment)? Thanks.

ankyhe · 2024-05-14T08:26:19Z

@dblock @bowenlan-amzn Could you have a check of this PR: opensearch-project/documentation-website#7039. Thanks.

Zhikai-VM requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami, tlfeng and VachaShah as code owners April 26, 2024 04:24

Zhikai-VM mentioned this pull request Apr 26, 2024

[BUG] The comments did not match the codes in MultiTermsAggregationBuilder #13375

Closed

github-actions bot added bug Something isn't working Search:Aggregations labels Apr 26, 2024

ankyhe reviewed Apr 26, 2024

View reviewed changes

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/370_multi_terms.yml Show resolved Hide resolved

dblock requested changes Apr 26, 2024

View reviewed changes

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/370_multi_terms.yml Show resolved Hide resolved

Zhikai-VM force-pushed the bug/issue-13375-add-test-case-for-multi-term-order branch from f5a9520 to a3a1f23 Compare April 27, 2024 01:47

Zhikai-VM force-pushed the bug/issue-13375-add-test-case-for-multi-term-order branch from a3a1f23 to 5257b82 Compare April 27, 2024 02:01

dblock added the skip-changelog label Apr 27, 2024

Zhikai-VM added 2 commits April 27, 2024 22:00

Add unit test cases for multiple terms aggregation:

e6bad8f

1. test case for multiple orders 2. test case for multiple orders and size Signed-off-by: Zhikai Chen <snoopy_czk@126.com>

Update the comments.

15e994e

Signed-off-by: Zhikai Chen <snoopy_czk@126.com>

Zhikai-VM force-pushed the bug/issue-13375-add-test-case-for-multi-term-order branch from bd340cf to 15e994e Compare April 27, 2024 14:00

Zhikai-VM requested a review from dblock April 27, 2024 22:45

Zhikai-VM requested a review from ankyhe April 28, 2024 00:35

dblock approved these changes Apr 29, 2024

View reviewed changes

dblock added the backport 2.x Backport to 2.x branch label Apr 29, 2024

dblock merged commit 4ee984f into opensearch-project:main Apr 29, 2024
33 checks passed

opensearch-trigger-bot bot mentioned this pull request Apr 29, 2024

[Backport 2.x] Add unit test of multipler orders for multiple terms aggregation. #13450

Merged

Zhikai-VM mentioned this pull request Apr 30, 2024

Update the example of the multiple terms aggregation by muliple orders. opensearch-project/documentation-website#7039

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit test of multipler orders for multiple terms aggregation. #13400

Add unit test of multipler orders for multiple terms aggregation. #13400

Zhikai-VM commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024

codecov bot commented Apr 26, 2024 •

edited

Loading

dblock left a comment

dblock commented Apr 26, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

dblock commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

Zhikai-VM commented Apr 28, 2024

dblock commented Apr 29, 2024

dblock commented Apr 29, 2024

Zhikai-VM commented Apr 29, 2024

ankyhe commented May 6, 2024

ankyhe commented May 14, 2024

Add unit test of multipler orders for multiple terms aggregation. #13400

Add unit test of multipler orders for multiple terms aggregation. #13400

Conversation

Zhikai-VM commented Apr 26, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Apr 26, 2024

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

dblock left a comment

Choose a reason for hiding this comment

dblock commented Apr 26, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

dblock commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

Zhikai-VM commented Apr 27, 2024

Zhikai-VM commented Apr 28, 2024

dblock commented Apr 29, 2024

dblock commented Apr 29, 2024

Zhikai-VM commented Apr 29, 2024

ankyhe commented May 6, 2024

ankyhe commented May 14, 2024

Zhikai-VM commented Apr 26, 2024 •

edited

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading