Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported version for the bug fix of from and size parameter can be negative when searching #13408

Merged
merged 3 commits into from
May 7, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Apr 26, 2024

Description

After the PR #13361 was backported to 2.x branch, we need to update the version check in main to ensure that the bwc tests can cover that bug fix.

Changelog is not needed, backport to 2.x is also not needed.

Related Issues

#11290

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…an be negative when searching

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

❕ Gradle check result for 1a11135: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.classMethod
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock
Copy link
Member

dblock commented Apr 26, 2024

@gaobinlong rebase? The unrelated failure looks suspicious.

Copy link
Contributor

✅ Gradle check result for d5eb993: SUCCESS

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (b15cb0c) to head (d5eb993).
Report is 264 commits behind head on main.

❗ Current head d5eb993 differs from pull request most recent head 835353f. Consider uploading reports for the commit 835353f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13408      +/-   ##
============================================
+ Coverage     71.42%   71.51%   +0.09%     
- Complexity    59978    60784     +806     
============================================
  Files          4985     5045      +60     
  Lines        282275   286080    +3805     
  Branches      40946    41432     +486     
============================================
+ Hits         201603   204593    +2990     
- Misses        63999    64539     +540     
- Partials      16673    16948     +275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Apr 29, 2024

@gaobinlong Can you please rebase again? I am not sure what's going on, @peterzhuamazon do you know?

Copy link
Contributor

github-actions bot commented May 6, 2024

❌ Gradle check result for 835353f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock dblock added the backport 2.x Backport to 2.x branch label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Gradle check result for 835353f: SUCCESS

@gaobinlong
Copy link
Collaborator Author

Hi @dblock , thanks for your review and approval, but backport to 2.x branch is not needed because the supported version in 2.x branch is correct.

@dblock dblock removed the backport 2.x Backport to 2.x branch label May 7, 2024
@dblock dblock merged commit a228dfc into opensearch-project:main May 7, 2024
30 checks passed
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…an be negative when searching (opensearch-project#13408)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…an be negative when searching (opensearch-project#13408)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…an be negative when searching (opensearch-project#13408)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants