-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover #13505
Merged
dblock
merged 1 commit into
opensearch-project:main
from
rahulkarajgikar:flaky-test-fix-1828
May 3, 2024
Merged
Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover #13505
dblock
merged 1 commit into
opensearch-project:main
from
rahulkarajgikar:flaky-test-fix-1828
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ClusterManagerFailover Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
rahulkarajgikar
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
May 2, 2024 11:06
github-actions
bot
added
bug
Something isn't working
Cluster Manager
flaky-test
Random test failure that succeeds on second run
labels
May 2, 2024
rahulkarajgikar
changed the title
Update Cluster Manager Node Timeout to 3s for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover
Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13505 +/- ##
===========================================
Coverage 71.42% 71.42%
- Complexity 59978 60957 +979
===========================================
Files 4985 5050 +65
Lines 282275 286805 +4530
Branches 40946 41552 +606
===========================================
+ Hits 201603 204843 +3240
- Misses 63999 65049 +1050
- Partials 16673 16913 +240 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
May 3, 2024
dblock
pushed a commit
that referenced
this pull request
May 3, 2024
…ClusterManagerFailover (#13505) (#13535) (cherry picked from commit 0c1cd75) Signed-off-by: Rahul Karajgikar <karajgik@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
finnegancarroll
pushed a commit
to finnegancarroll/OpenSearch
that referenced
this pull request
May 10, 2024
…ClusterManagerFailover (opensearch-project#13505) Signed-off-by: Rahul Karajgikar <karajgik@amazon.com> Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
May 17, 2024
…ClusterManagerFailover (opensearch-project#13505) Signed-off-by: Rahul Karajgikar <karajgik@amazon.com> Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…ClusterManagerFailover (opensearch-project#13505) Signed-off-by: Rahul Karajgikar <karajgik@amazon.com> Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
bug
Something isn't working
Cluster Manager
flaky-test
Random test failure that succeeds on second run
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses fix for Flaky Test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover which is caused in scenarios of master node not being able to bootup within 2 minutes occasionally
This change increases the time limit to 3 minutes which will reduce flakiness.
In 5k runs with previous setting of 2 minutes, saw 5 failures.
In 5k runs with new setting of 3 minutes, saw 0 failures
Related Issues
Resolves #1828
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.