Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover #13505

Merged

Conversation

rahulkarajgikar
Copy link
Contributor

@rahulkarajgikar rahulkarajgikar commented May 2, 2024

Description

Addresses fix for Flaky Test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover which is caused in scenarios of master node not being able to bootup within 2 minutes occasionally

This change increases the time limit to 3 minutes which will reduce flakiness.
In 5k runs with previous setting of 2 minutes, saw 5 failures.
In 5k runs with new setting of 3 minutes, saw 0 failures

Related Issues

Resolves #1828

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ClusterManagerFailover

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
@github-actions github-actions bot added bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run labels May 2, 2024
@rahulkarajgikar rahulkarajgikar changed the title Update Cluster Manager Node Timeout to 3s for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

✅ Gradle check result for bb5e9a4: SUCCESS

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (b15cb0c) to head (bb5e9a4).
Report is 262 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main   #13505     +/-   ##
===========================================
  Coverage     71.42%   71.42%             
- Complexity    59978    60957    +979     
===========================================
  Files          4985     5050     +65     
  Lines        282275   286805   +4530     
  Branches      40946    41552    +606     
===========================================
+ Hits         201603   204843   +3240     
- Misses        63999    65049   +1050     
- Partials      16673    16913    +240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 0c1cd75 into opensearch-project:main May 3, 2024
70 of 101 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label May 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
…ClusterManagerFailover (#13505)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
(cherry picked from commit 0c1cd75)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request May 3, 2024
…ClusterManagerFailover (#13505) (#13535)

(cherry picked from commit 0c1cd75)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…ClusterManagerFailover (opensearch-project#13505)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…ClusterManagerFailover (opensearch-project#13505)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…ClusterManagerFailover (opensearch-project#13505)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Co-authored-by: Rahul Karajgikar <karajgik@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run skip-changelog
Projects
Status: ✅ Done
2 participants