Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct names for snapshot indices while updating remote store index settings #13529

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented May 3, 2024

Description

Pass correct names for snapshot indices

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for faab013: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 11, 2024
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@ltaragi ltaragi force-pushed the snapshot-indices-names branch from b880a1c to de5c723 Compare June 11, 2024 05:01
Copy link
Contributor

❕ Gradle check result for b880a1c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (b15cb0c) to head (de5c723).
Report is 393 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13529      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    61791    +1813     
============================================
  Files          4985     5105     +120     
  Lines        282275   290072    +7797     
  Branches      40946    41902     +956     
============================================
+ Hits         201603   207906    +6303     
- Misses        63999    65022    +1023     
- Partials      16673    17144     +471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for de5c723: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit cf2c31f into opensearch-project:main Jun 11, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
…ndex settings (#13529)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit cf2c31f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jun 11, 2024
…ndex settings (#13529) (#14166)

(cherry picked from commit cf2c31f)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ndex settings (opensearch-project#13529) (opensearch-project#14166)

(cherry picked from commit cf2c31f)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ndex settings (opensearch-project#13529)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Remote v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants