Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TODO for Updating API Spec #13621

Merged
merged 3 commits into from
May 10, 2024
Merged

Add TODO for Updating API Spec #13621

merged 3 commits into from
May 10, 2024

Conversation

kkhatua
Copy link
Member

@kkhatua kkhatua commented May 10, 2024 •
edited by reta
Loading

Description

Added a TODO in the checklist for contributors to add API Specs when introducing new user APIs

Related Issues

Resolves #13619

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

Add TODO for Updating API Spec
873837c 
Added a TODO in the checklist for contributors to add API Specs when
introducing new user APIs
@kkhatua kkhatua requested a review from peternied as a code owner May 10, 2024 05:16
@github-actions github-actions bot added Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request labels May 10, 2024
@kkhatua kkhatua requested review from dblock and removed request for peternied May 10, 2024 05:16
@kkhatua kkhatua self-assigned this May 10, 2024
@kkhatua kkhatua added community Issues raised by community members and contributors and removed enhancement Enhancement or improvement to existing feature or request labels May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 873837c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.48%. Comparing base (b15cb0c) to head (772e339).
Report is 274 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13621      +/-   ##
============================================
+ Coverage     71.42%   71.48%   +0.06%     
- Complexity    59978    61027    +1049     
============================================
  Files          4985     5052      +67     
  Lines        282275   287143    +4868     
  Branches      40946    41607     +661     
============================================
+ Hits         201603   205260    +3657     
- Misses        63999    64925     +926     
- Partials      16673    16958     +285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkhatua @peternied
Update .github/pull_request_template.md
ce9471f 
Co-authored-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Kunal Khatua <kkhatua@users.noreply.github.com>
@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label May 10, 2024
@peternied
Remove redundant checkbox
772e339 
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
peternied approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @reta @andrross any concerns?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for ce9471f: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 772e339: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator

reta commented May 10, 2024

DCO check is failing :(

@peternied peternied merged commit cd55bca into opensearch-project:main May 10, 2024
32 of 34 checks passed
@peternied
Copy link
Member

I've approved and squashed it with correct sign-off statements

finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
@kkhatua @peternied @finnegancarroll
Add TODO for Updating API Spec (opensearch-project#13621)
3bd9469 
Signed-off-by: Kunal Khatua <kkhatua@amazon.com>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Peter Nied <petern@amazon.com>
@kkhatua
Copy link
Member Author

kkhatua commented May 11, 2024

Thanks @reta and @peternied !
I didn't realize that non-code changes to the checklist also required the entire checklist. #ironic 😇

Will take care and follow protocol

@kkhatua kkhatua deleted the add-api-spec-checklist branch May 11, 2024 01:19
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
@kkhatua @peternied @deshsidd
Add TODO for Updating API Spec (opensearch-project#13621)
4acdc24 
Signed-off-by: Kunal Khatua <kkhatua@amazon.com>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Peter Nied <petern@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@kkhatua @peternied @parv0201
Add TODO for Updating API Spec (opensearch-project#13621)
11985dc 
Signed-off-by: Kunal Khatua <kkhatua@amazon.com>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Peter Nied <petern@amazon.com>
@dblock dblock mentioned this pull request Jul 8, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@peternied peternied peternied approved these changes

@dblock dblock Awaiting requested review from dblock

Assignees

@kkhatua kkhatua

Labels
Clients Clients within the Core repository such as High level Rest client and low level client community Issues raised by community members and contributors enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add TODO for Updating API Spec
3 participants
@kkhatua @reta @peternied