Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Split the remote global metadata file to metadata attribute files #13703

Merged
merged 3 commits into from
Jun 5, 2024
Merged

[Backport 2.x] Split the remote global metadata file to metadata attribute files #13703

merged 3 commits into from
Jun 5, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented May 16, 2024 •
edited
Loading

Backport da3ab92, 2e49743 from #12190, #13869

@shiv0408 shiv0408 changed the base branch from backport/backport-12190-to-2.x to 2.x May 16, 2024 09:38
@shiv0408 shiv0408 mentioned this pull request May 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 57dc35c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 force-pushed the backport/backport-12190-to-2.x branch 2 times, most recently from 4f9e367 to d7fd2f8 Compare May 17, 2024 11:49
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4f9e367: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.19321% with 98 lines in your changes missing coverage. Please review.

Project coverage is 71.31%. Comparing base (0dd892c) to head (077e60b).
Report is 295 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 73.80% 60 Missing and 6 partials ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 88.02% 12 Missing and 5 partials ⚠️
...opensearch/cluster/metadata/TemplatesMetadata.java 74.50% 11 Missing and 2 partials ⚠️
...nsearch/cluster/metadata/RepositoriesMetadata.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13703      +/-   ##
============================================
+ Coverage     71.28%   71.31%   +0.02%     
- Complexity    60145    61412    +1267     
============================================
  Files          4957     5040      +83     
  Lines        282799   288738    +5939     
  Branches      41409    42178     +769     
============================================
+ Hits         201591   205907    +4316     
- Misses        64189    65509    +1320     
- Partials      17019    17322     +303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for d7fd2f8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for b7fe838: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

I just rebased with the latest from 2.x, which should fix the DCO issue.

@andrross seeing this error now

fd8b92c20bc950941d3a10b6f09bc4220246f577    Expected "Shivansh Arora <31575408+shiv0408@users.noreply.github.com>", but got "Shivansh Arora <hishiv@amazon.com>".

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for b7fe838: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 force-pushed the backport/backport-12190-to-2.x branch 2 times, most recently from bd162eb to 52f4f27 Compare June 5, 2024 11:53
shiv0408 and others added 3 commits June 5, 2024 17:34
@shiv0408
Split the remote global metadata file to metadata attribute files (op…
3decfcc 
…ensearch-project#12190)

* Split the cluster state remote global metadata file to metadata attribute files

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit da3ab92)
@shiv0408
Update version check in ClusterMetadataManifest
053d81d 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@shiv0408
Remove conflicting static method from Metadata.Custom interface
077e60b 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@shiv0408 shiv0408 force-pushed the backport/backport-12190-to-2.x branch from 52f4f27 to 077e60b Compare June 5, 2024 12:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for bd162eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❕ Gradle check result for 52f4f27: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❕ Gradle check result for 077e60b: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@shwetathareja shwetathareja merged commit 1525a3f into opensearch-project:2.x Jun 5, 2024
30 checks passed
@shiv0408 shiv0408 deleted the backport/backport-12190-to-2.x branch June 5, 2024 14:14
This was referenced Jun 13, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 27, 2024
Open
Open
Closed
Open
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@shiv0408 @kkewwei
[Backport 2.x] Split the remote global metadata file to metadata attr…
bfe05e9 
…ibute files (opensearch-project#13703)

* Split the remote global metadata file to metadata attribute files (opensearch-project#12190)

* Split the cluster state remote global metadata file to metadata attribute files

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit da3ab92)

* Remove conflicting static method from Metadata.Custom interface

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

---------

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@shiv0408 shiv0408 self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied left review comments

@reta reta reta left review comments

@andrross andrross andrross approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@shiv0408 shiv0408

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shiv0408 @andrross @shwetathareja @reta @peternied