-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DerivedField] object type support in mappings and new settings for derived field #13717
[DerivedField] object type support in mappings and new settings for derived field #13717
Conversation
❌ Gradle check result for b5fd4b9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Once we merge #13592, I think you'll need to rebase this (to avoid the redundant classes). I'll let you know once I've merged that one, then you can let me know once you've rebased this one.
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
36cae9d
to
6e35862
Compare
…erived field (opensearch-project#13717) --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…erived field (opensearch-project#13717) --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…erived field (#13717) (#14050) --------- (cherry picked from commit bb013da) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…erived field (opensearch-project#13717) --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…erived field (opensearch-project#13717) (opensearch-project#14050) --------- (cherry picked from commit bb013da) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
…erived field (opensearch-project#13717) --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Description
Introduces object type definition and following settings -
source_indexed_field
: This indexed field should be of typetext
and will be used to filter documents in 2 phased iterator approach before executing the expensiveDerivedFieldQuery
fetching from source, running script, deriving value, creating memory index. This is to improve the performance forobject
type.properties
: fieldname and field type can be specified explicity to avoid inferring the type of sub fields within object type.format
: date format to be used when type is inferred. Unrelated to object type and applicable to date type for both nested and non-nested fields.ignore_malformed
: ignores malformed documents for cases when field value cannot be derived or there is a type mismatch. If set to true, the query will ignore such documents and proceeds with rest of the matching documents.Example -
Diff will reduce once preceding PR is merged: #13592
Related Issues
Resolves #13715
#13592
Check List
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.