Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery chunk size setting #13997

Merged
merged 15 commits into from
Jun 10, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented Jun 5, 2024

Description

Making recovery chunk size setting dynamic. This will be required to increase the recovery chunk size while non-remote to remote-store migration is happening. Default value is 512 KB.

Related Issues

Resolves [#14001]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
@astute-decipher astute-decipher self-assigned this Jun 5, 2024
@astute-decipher astute-decipher marked this pull request as ready for review June 5, 2024 12:09
@gbbafna gbbafna changed the title Making recovery chunk size setting dynamic Add recovery chunk size setting Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 3013bac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna merged commit 53ea952 into opensearch-project:main Jun 10, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
(cherry picked from commit 53ea952)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
astute-decipher added a commit to astute-decipher/OpenSearch that referenced this pull request Jun 11, 2024
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch Storage:Remote
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants