Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Optimize remote state stale file deletion (#13995) #14025

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jun 6, 2024

(cherry picked from commit 3de5d3c)

Description

Backport 3de5d3c from #13995

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shiv0408 shiv0408 changed the title Optimize remote state stale file deletion (#13995) [Backport 2.x] Optimize remote state stale file deletion (#13995) Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❕ Gradle check result for 4490b3f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 41f493f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 01f1499: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 7af2741: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 force-pushed the 2.x branch 2 times, most recently from 9eea466 to b1aaddd Compare June 7, 2024 19:37
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 9eea466: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for b1aaddd:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

(cherry picked from commit 3de5d3c)
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

✅ Gradle check result for 48a0eb0: SUCCESS

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 77.95699% with 41 lines in your changes missing coverage. Please review.

Project coverage is 71.32%. Comparing base (0dd892c) to head (48a0eb0).
Report is 317 commits behind head on 2.x.

Files Patch % Lines
...teway/remote/RemoteClusterStateCleanupManager.java 79.31% 29 Missing and 7 partials ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 55.55% 3 Missing and 1 partial ⚠️
server/src/main/java/org/opensearch/node/Node.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14025      +/-   ##
============================================
+ Coverage     71.28%   71.32%   +0.04%     
- Complexity    60145    61491    +1346     
============================================
  Files          4957     5050      +93     
  Lines        282799   289150    +6351     
  Branches      41409    42221     +812     
============================================
+ Hits         201591   206245    +4654     
- Misses        64189    65593    +1404     
- Partials      17019    17312     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants