Fix the rewrite method for MatchOnlyText field query

[rishabhmaurya]

Description

Using indexSearcher.rewrite(delegateQuery) instead of delegateQuery.rewrite(indexSearcher); can have side effects when profile is set to true, as it can start reusing the profile objects created in parent query and can interfere with timers if they were already started. Whereas, query.rewrite(indexSearcher) it just uses the lucene APIs and doesn't use the wrapped functionality in OpenSearch.

In query phase, when rewrite is called

OpenSearch/server/src/main/java/org/opensearch/search/query/QueryPhase.java

Line 127 in 5ff50a7

context.preProcess(true);

the ContextIndexSearch will start the timer for the query and will start noting the rewrite() time for all clauses in the clauses for the complete query tree.

But if we try to use indexSearcher.rewrite(delegateQuery) within rewrite of any of the query, it will try to initialize the profiler and timer again and will result in the assertion error here -

OpenSearch/server/src/main/java/org/opensearch/search/profile/query/AbstractQueryProfileTree.java

Line 48 in 200ad5d

assert rewriteScratch == 0;

»  java.lang.AssertionError
»       at org.opensearch.search.profile.query.AbstractQueryProfileTree.startRewriteTime(AbstractQueryProfileTree.java:48)
»       at org.opensearch.search.profile.query.QueryProfiler.startRewriteTime(QueryProfiler.java:80)
»       at org.opensearch.search.internal.ContextIndexSearcher.rewrite(ContextIndexSearcher.java:192)
»       at org.opensearch.index.query.SourceFieldMatchQuery.rewrite(SourceFieldMatchQuery.java:76)
»       at org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:777)
»       at org.opensearch.search.internal.ContextIndexSearcher.rewrite(ContextIndexSearcher.java:196)
»       at org.opensearch.search.DefaultSearchContext.preProcess(DefaultSearchContext.java:362)
»       at org.opensearch.search.query.QueryPhase.preProcess(QueryPhase.java:127)
»       at org.opensearch.search.SearchService.createContext(SearchService.java:1053)

Related Issues

Fixes #14156

Check List

• [ ] Functionality includes testing. There are already unit and integ tests present for match_only_text field.
• [ ] API changes companion pull request created, if applicable.
• [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for e911b4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for f31b3b0: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (b15cb0c) to head (0fe4f72).
Report is 416 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14154      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    62012    +2034     
============================================
  Files          4985     5117     +132     
  Lines        282275   291686    +9411     
  Branches      40946    42166    +1220     
============================================
+ Hits         201603   209059    +7456     
- Misses        63999    65356    +1357     
- Partials      16673    17271     +598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for ffd19d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 0fe4f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[rishabhmaurya]

test failures are flaky tests - #13540 and #14243
@reta can we merge it with these failing flaky test?

[github-actions]

❌ Gradle check result for 0fe4f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[rishabhmaurya]

hitting another flaky test - #5329

[reta]

@reta can we merge it with these failing flaky test?

No merges with failing checks please, @rishabhmaurya could you please add entry to https://github.com/opensearch-project/OpenSearch/blob/main/release-notes/opensearch.release-notes-2.15.0.md? (we could do it in separate pull request if checks are green for this one)

[github-actions]

❕ Gradle check result for 0fe4f72: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[rishabhmaurya]

#14251 to add this change to 2.15 release notes.