Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x]Create Remote Object managers and use them in orchestration from Remo… #14188

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[Backport 2.x]Create Remote Object managers and use them in orchestration from Remo… #14188

merged 1 commit into from
Jun 11, 2024

Conversation

soosinha
Copy link
Member

  • Create Remote Object managers and use them in orchestration from RemoteClusterStateService

Backport from #13924

@shiv0408 @soosinha
Create Remote Object managers and use them in orchestration from Remo…
d143a54 
…teClusterStateService (opensearch-project#13924)

* Create Remote Object managers and use them in orchestration from RemoteClusterStateService

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d143a54: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 86.21701% with 47 lines in your changes missing coverage. Please review.

Project coverage is 71.32%. Comparing base (0dd892c) to head (d143a54).
Report is 350 commits behind head on 2.x.

Files Patch % Lines
...ensearch/gateway/remote/RemoteManifestManager.java 80.20% 16 Missing and 3 partials ⚠️
...ch/gateway/remote/RemoteGlobalMetadataManager.java 86.58% 5 Missing and 6 partials ⚠️
...teway/remote/RemoteClusterStateCleanupManager.java 85.71% 2 Missing and 2 partials ⚠️
...rch/gateway/remote/RemoteIndexMetadataManager.java 86.66% 3 Missing and 1 partial ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 97.46% 2 Missing ⚠️
...arch/gateway/remote/model/RemoteClusterBlocks.java 0.00% 1 Missing ⚠️
...ay/remote/model/RemoteClusterMetadataManifest.java 0.00% 1 Missing ⚠️
...ateway/remote/model/RemoteClusterStateCustoms.java 0.00% 1 Missing ⚠️
...rch/gateway/remote/model/RemoteDiscoveryNodes.java 0.00% 1 Missing ⚠️
...remote/model/RemoteHashesOfConsistentSettings.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14188      +/-   ##
============================================
+ Coverage     71.28%   71.32%   +0.04%     
- Complexity    60145    62016    +1871     
============================================
  Files          4957     5094     +137     
  Lines        282799   291891    +9092     
  Branches      41409    42530    +1121     
============================================
+ Hits         201591   208192    +6601     
- Misses        64189    66189    +2000     
- Partials      17019    17510     +491

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit a2f7954 into opensearch-project:2.x Jun 11, 2024
56 of 57 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 13, 2024
Open
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@soosinha @shiv0408 @kkewwei
Create Remote Object managers and use them in orchestration from Remo…
429fce4 
…teClusterStateService (opensearch-project#13924) (opensearch-project#14188)

* Create Remote Object managers and use them in orchestration from RemoteClusterStateService

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Co-authored-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soosinha @shwetathareja @shiv0408