-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust CodeCache size to eliminate JVM warnings (and crashes) #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
✅ Gradle Wrapper Validation success ab72efe |
Can one of the admins verify this patch? |
✅ DCO Check Passed ab72efe |
✅ Gradle Precommit success ab72efe |
start gradle check |
The log is clean, no CodeCache warnings, to compare - https://ci.opensearch.org/logs/ci/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/gradle_check_791.log, previous build for another PR:
|
dblock
approved these changes
Oct 22, 2021
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Oct 25, 2021
…arch-project#1426) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
5 tasks
dblock
pushed a commit
that referenced
this pull request
Oct 26, 2021
nknize
pushed a commit
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
During the build, there are JVM warnings popping up from time to time:
Also, a very rare crashes are observed (first seen in #1408, related to https://bugs.openjdk.java.net/browse/JDK-8248519):
The suggested fix is to increase CodeCache size a bit (from 48m to 64m).
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.