fix FuzzyQuery in keyword field will use IndexOrDocValuesQuery when both of index and doc_value are true

[kkewwei]

Description

Fix FuzzyQuery in keyword field will use IndexOrDocValuesQuery when both of index and doc_value are true.

Related Issues

Resolves #14377

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kkewwei]

@harshavamsi @msfroh, please help review the code when you are free, I am very grateful for this.

[github-actions]

✅ Gradle check result for d843cdd: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (b15cb0c) to head (5e7ab2a).
Report is 475 commits behind head on main.

Files	Patch %	Lines
...a/org/opensearch/index/mapper/StringFieldType.java	66.66%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14378      +/-   ##
============================================
+ Coverage     71.42%   71.66%   +0.24%     
- Complexity    59978    62152    +2174     
============================================
  Files          4985     5125     +140     
  Lines        282275   292352   +10077     
  Branches      40946    42243    +1297     
============================================
+ Hits         201603   209526    +7923     
- Misses        63999    65538    +1539     
- Partials      16673    17288     +615     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Gradle check result for c873c43: SUCCESS

[kkewwei]

null

❌ Gradle check result for 751fc36: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringQueryPhase #13674
RecoveryFromGatewayIT.testMultipleReplicaShardAssignmentWithDelayedAllocationAndDifferentNodeStartTimeInBatchMode #14346
RemoteSplitIndexIT.classMethod #13828

[kkewwei]

@dblock, please have a another look when you are free.

[dblock]

I'm not super familiar with this code, maybe @andrross or someone else is?

[github-actions]

✅ Gradle check result for 2326e62: SUCCESS

[kkewwei]

@andrross please help merge, thank you.

[github-actions]

✅ Gradle check result for ba4b35f: SUCCESS

[github-actions]

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchWithRandomExceptionsIT.testRandomExceptions #14144

[github-actions]

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 5e7ab2a: SUCCESS

Looks good to me