[Backport 2.x] Remove one unnecessary test and simply some code in a test #14412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
andrross
approved these changes
Jun 17, 2024
|
❌ Gradle check result for 7dfa6e5: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit 1d14569) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
force-pushed
the
backport/backport-14360-to-2.x
branch
from
7dfa6e5
to
aabec3f
Compare
|
❌ Gradle check result for aabec3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14412 +/- ##
============================================
- Coverage 71.59% 71.54% -0.06%
+ Complexity 62621 62553 -68
============================================
Files 5110 5110
Lines 293685 293685
Branches 42801 42801
============================================
- Hits 210265 210112 -153
- Misses 65801 65898 +97
- Partials 17619 17675 +56 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Jul 23, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…-project#14360) (opensearch-project#14412) (cherry picked from commit 1d14569) Signed-off-by: Liyun Xiu <xiliyun@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1d14569 from #14360.