Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListPitInfo::getKeepAlive() getter #14495

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add ListPitInfo::getKeepAlive() getter #14495

merged 1 commit into from
Jun 21, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 21, 2024

Description

Add ListPitInfo::getKeepAlive() getter

Related Issues

Coming from opensearch-project/spring-data-opensearch#218, we forgot to include the getter for keepAlive property.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta force-pushed the add.keep.alive branch from 332cf3f to d65bed4 Compare June 21, 2024 17:06
@reta reta added bug Something isn't working backport 2.x Backport to 2.x branch v2.16.0 Issues and PRs related to version 2.16.0 and removed skip-changelog labels Jun 21, 2024
@reta reta mentioned this pull request Jun 21, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 332cf3f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d65bed4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the add.keep.alive branch from d65bed4 to 46bcba7 Compare June 21, 2024 17:34
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 46bcba7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the add.keep.alive branch from 46bcba7 to 0845278 Compare June 21, 2024 18:46
@reta
Add ListPitInfo::getKeepAlive() getter
76c4c57 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the add.keep.alive branch from 0845278 to 76c4c57 Compare June 21, 2024 18:47
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0845278: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 76c4c57: SUCCESS

@reta reta added the v3.0.0 Issues and PRs related to version 3.0.0 label Jun 21, 2024
@andrross andrross merged commit f8e8865 into opensearch-project:main Jun 21, 2024
32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 21, 2024
@github-actions
Add ListPitInfo::getKeepAlive() getter (#14495)
c10853f 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit f8e8865)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 21, 2024
Merged
andrross pushed a commit that referenced this pull request Jun 21, 2024
@opensearch-trigger-bot @github-actions
Add ListPitInfo::getKeepAlive() getter (#14495) (#14501)
4a92ccc 
(cherry picked from commit f8e8865)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@reta @harshavamsi
Add ListPitInfo::getKeepAlive() getter (opensearch-project#14495)
427bcb5 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@finnegancarroll finnegancarroll mentioned this pull request Jul 15, 2024
Closed
3 tasks
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Add ListPitInfo::getKeepAlive() getter (opensearch-project#14495) (op…
30b2e3d 
…ensearch-project#14501)

(cherry picked from commit f8e8865)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@reta
Add ListPitInfo::getKeepAlive() getter (opensearch-project#14495)
5ae704f 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working v2.16.0 Issues and PRs related to version 2.16.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @andrross