Segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase

[rampreeth]

Description

Fixes segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase

Related Issues

Resolves #11945

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for ec6091b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for aca2198: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 0603be3: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (b82ed5a) to head (ba5b8c1).
Report is 32 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14580      +/-   ##
============================================
+ Coverage     72.29%   72.68%   +0.38%     
- Complexity    65699    66041     +342     
============================================
  Files          5318     5318              
  Lines        305676   305677       +1     
  Branches      44350    44350              
============================================
+ Hits         220992   222170    +1178     
+ Misses        66582    65616     -966     
+ Partials      18102    17891     -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[rampreeth]

@shourya035 , I didn't get a chance to address the comments, will be doing that this week

[rampreeth]

@mch2 , could I please get a review on this?

[github-actions]

✅ Gradle check result for ba5b8c1: SUCCESS

[mch2]

Thanks for the fix @rampreeth, FYI @vinaykpud is working on a change to simplify segrep stats by pushing the computation to the replicas - #17055.

[rampreeth]

Thanks for the fix @rampreeth, FYI @vinaykpud is working on a change to simplify segrep stats by pushing the computation to the replicas - #17055.

Got it. Thanks @mch2 for the review.

[github-actions]

✅ Gradle check result for ba5b8c1: SUCCESS

[rampreeth]

@mch2 , I see that there are 6 workflows that are expected to run but doesn't seem to be running. Could you please help with that? Does it need approval?

[sachinpkale]

@rampreeth Please update the PR description

[rampreeth]

@sachinpkale @mch2 , would you be able to merge the PR?