[Star tree] Star tree merge changes #14652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-techie
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 948419f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
force-pushed
the
star_onheap_merge
branch
2 times, most recently
from
1784c9b
to
6f5befd
Compare
|
❌ Gradle check result for 1784c9b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
force-pushed
the
star_onheap_merge
branch
from
6f5befd
to
db1eb0d
Compare
github-actions
bot
added
enhancement
bharath-techie
force-pushed
the
star_onheap_merge
branch
from
db1eb0d
to
5c8eb14
Compare
bharath-techie
force-pushed
the
star_onheap_merge
branch
from
aa04916
to
c55460f
Compare
server/src/main/java/org/opensearch/index/codec/composite/Composite99DocValuesWriter.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
mgodwan
reviewed
Jul 19, 2024
server/src/main/java/org/opensearch/index/codec/composite/Composite99DocValuesWriter.java
Show resolved
Hide resolved
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
bharath-techie
force-pushed
the
star_onheap_merge
branch
from
bdbe58e
to
21f9ff0
Compare
|
❌ Gradle check result for bdbe58e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
reviewed
Jul 22, 2024
server/src/main/java/org/opensearch/index/codec/composite/Composite99DocValuesWriter.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/codec/composite/Composite99DocValuesWriter.java
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
…star_onheap_merge
|
❕ Gradle check result for a1957f7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
mgodwan
reviewed
Jul 23, 2024
server/src/main/java/org/opensearch/index/codec/composite/Composite99DocValuesWriter.java
Show resolved
Hide resolved
mgodwan
approved these changes
Jul 23, 2024
sarthakaggarwal97
approved these changes
Jul 23, 2024
sachinpkale
approved these changes
Jul 24, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
--------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
--------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
--------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit 312de99) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Aug 24, 2024
--------- (cherry picked from commit 312de99) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Star tree merge changes.
Instead of constructing the star tree by again scanning through all the segment docs, we will use the already aggregated star tree doc values from the segments.
We will take the non star rows of the dimension fields from the aggregated doc values and construct the star tree
For example, consider the following segments with star tree aggregated documents ,
Segment 1 : [ we will take 0 - 3 ]
Segment 2 : [ we will take 0 - 2 ]
Merged segment initial star tree documents : [ initially just form the records ]
From here on we'll sort the documents, aggregate the documents and construct the star tree , similar to the flush flow.
Related Issues
Resolves #14626
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.