[Backport 2.x] Refactor Grok validate pattern to iterative approach #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* grok validate patterns recusrion to iterative Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Add max depth in resolving a pattern to avoid OOM Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * change path from deque to arraylist Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * rename queue to stack Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Change max depth to 500 Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * typo originPatternName fix Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * spotless Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit 13f04d9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 3c783e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3c783e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3c783e1: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14693 +/- ##
============================================
+ Coverage 71.42% 71.43% +0.01%
+ Complexity 62382 62354 -28
============================================
Files 5103 5103
Lines 293268 293294 +26
Branches 42730 42734 +4
============================================
+ Hits 209478 209529 +51
+ Misses 66236 66161 -75
- Partials 17554 17604 +50 ☔ View full report in Codecov by Sentry. |
mch2
approved these changes
Jul 10, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…ect#14206) (opensearch-project#14693) * grok validate patterns recusrion to iterative * Add max depth in resolving a pattern to avoid OOM * change path from deque to arraylist * rename queue to stack * Change max depth to 500 * typo originPatternName fix * spotless --------- (cherry picked from commit 13f04d9) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 13f04d9 from #14206.