[DRAFT] Create Snapshot checkpointing on Cluster Manager #14704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 3, 2024 12:05
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
changed the title
|
❌ Gradle check result for 41d77a2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
vikasvb90
reviewed
Jul 15, 2024
| assert assertShardsConsistent(this.source, this.state, this.indices, this.shards, this.clones); | ||
| this.centralSnap = centralSnap; | ||
| if (!centralSnap) { | ||
| assert assertShardsConsistent(this.source, this.state, this.indices, this.shards, this.clones); |
There was a problem hiding this comment.
Why is this assertion not valid in this case?
There was a problem hiding this comment.
Also, can you please name centralSnap better and update PR description on what you intend to do in this PR for early feedback?
| return; | ||
| } | ||
| try { | ||
| logger.info( |
| ActionListener.wrap(snapshot -> addListener(snapshot, ActionListener.map(listener, Tuple::v2)), listener::onFailure) | ||
| ); | ||
| if (isCentralSnap) { | ||
| createSnapshotCentralized( |
There was a problem hiding this comment.
Lets name this better. centralized doesn't really convey its intent clearly.
| final String repositoryName = request.repository(); | ||
| final String snapshotName = indexNameExpressionResolver.resolveDateMathExpression(request.snapshot()); | ||
|
|
||
| createSnapshotValidations(request, listener); |
There was a problem hiding this comment.
createSnapshotValidations to validate...
| @Override | ||
| public void clusterStateProcessed(String source, ClusterState oldState, final ClusterState newState) { | ||
| try { | ||
| logger.info("snapshot [{}] started", snapshot); |
| @Override | ||
| public void onResponse(Collection<Void> result) { | ||
| // Final step after all shards are processed | ||
| logger.info( |
| final String repositoryName = request.repository(); | ||
| final String snapshotName = indexNameExpressionResolver.resolveDateMathExpression(request.snapshot()); | ||
| validate(repositoryName, snapshotName); | ||
| // TODO: create snapshot UUID in CreateSnapshotRequest and make this operation idempotent to cleanly deal with transport layer |
There was a problem hiding this comment.
Couple of questions:
- If this is not idempotent then your in-memory map of maintaining status of create snapshot operations is also not serving any purpose now. Is this correct?
- After you create UUIDs at REST layer, in what scenarios do you see create snapshot being invoked multiple times for same UUIDs?
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.