-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support rangeQuery and regexpQuery in constant_keyword field type #14711
Conversation
72a3ba8
to
3cd9c3e
Compare
❌ Gradle check result for 72a3ba8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14711 +/- ##
============================================
- Coverage 71.87% 71.86% -0.01%
- Complexity 62811 62824 +13
============================================
Files 5169 5169
Lines 294646 294663 +17
Branches 42610 42616 +6
============================================
- Hits 211778 211773 -5
- Misses 65415 65447 +32
+ Partials 17453 17443 -10 ☔ View full report in Codecov by Sentry. |
@gaobinlon, can you please have a look when you are free, thank you. |
@dblock can you help review the PR? very thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Definitely needs a CHANGELOG.
Please don't forget to add spec and tests to https://github.com/opensearch-project/opensearch-api-specification.
50459c2
to
5ac62b4
Compare
❌ Gradle check result for 50459c2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e72dae3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for abb776f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rest-api-spec/src/main/resources/rest-api-spec/test/index/110_constant_keyword.yml
Show resolved
Hide resolved
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com> add rest api spec tests Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
abb776f
to
0ebfcb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfroh your concerns cleared out? thanks!
Not yet!
The idea is that if we do move it to the parent, then we can support these query types on index names. Again, though -- I think we can safely defer that to another issue. (I don't even know if anyone actually wants to be able to filter on index names by range or regex.) |
…ensearch-project#14711) --------- Signed-off-by: kkewwei <kkewwei@163.com>
…ensearch-project#14711) --------- Signed-off-by: kkewwei <kkewwei@163.com>
…ensearch-project#14711) --------- Signed-off-by: kkewwei <kkewwei@163.com>
Description
Support rangeQuery and regexpQuery in constant_keyword field type
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.