Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Removing String format in RemoteStoreMigrationAllocationDecider #14874

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Backport 2.x] Removing String format in RemoteStoreMigrationAllocationDecider #14874

merged 1 commit into from
Jul 23, 2024

Conversation

RS146BIJAY
Copy link
Contributor

Backport e82b432 from #14612.

@RS146BIJAY
Removing String format in RemoteStoreMigrationAllocationDecider to op…
35c5c60 
…timise performance(opensearch-project#14612)

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
(cherry picked from commit e82b432)
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 35c5c60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Jul 22, 2024

Any reason this is not ready for review @RS146BIJAY?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 35c5c60: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 35c5c60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 35c5c60: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (7755055) to head (35c5c60).
Report is 8 commits behind head on 2.x.

Files Patch % Lines
...decider/RemoteStoreMigrationAllocationDecider.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x   #14874   +/-   ##
=========================================
  Coverage     71.58%   71.58%           
+ Complexity    62544    62494   -50     
=========================================
  Files          5108     5108           
  Lines        293645   293653    +8     
  Branches      42781    42781           
=========================================
+ Hits         210205   210215   +10     
- Misses        65741    65780   +39     
+ Partials      17699    17658   -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RS146BIJAY RS146BIJAY marked this pull request as ready for review July 23, 2024 05:34
@RS146BIJAY
Copy link
Contributor Author

RS146BIJAY commented Jul 23, 2024 •
edited
Loading

Any reason this is not ready for review @RS146BIJAY?

I was waiting for the build to pass. Published the PR.

@Bukhtawar Bukhtawar merged commit 16ee25c into opensearch-project:2.x Jul 23, 2024
56 of 57 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@RS146BIJAY @kkewwei
Removing String format in RemoteStoreMigrationAllocationDecider to op…
1c21b08 
…timise performance(opensearch-project#14612) (opensearch-project#14874)

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: kkewwei <kkewwei@163.com>
This was referenced Sep 6, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RS146BIJAY @dblock @Bukhtawar