Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [BUG FIX] Fix the visit of inner query for NestedQueryBuilder #14967

Merged

Conversation

zhichao-aws
Copy link
Member

Description

backport #14379 , solve the conflict in CHANGELOG.md

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Copy link
Contributor

❌ Gradle check result for 01aaa4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 01aaa4b: SUCCESS

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (7223644) to head (01aaa4b).

Files Patch % Lines
...org/opensearch/index/query/NestedQueryBuilder.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14967      +/-   ##
============================================
- Coverage     71.58%   71.57%   -0.02%     
+ Complexity    62774    62765       -9     
============================================
  Files          5123     5123              
  Lines        294467   294471       +4     
  Branches      42909    42910       +1     
============================================
- Hits         210808   210780      -28     
- Misses        65990    66026      +36     
+ Partials      17669    17665       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong gaobinlong merged commit c6981d3 into opensearch-project:2.x Jul 25, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants