Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15126

gaobinlong · 2024-08-06T14:12:21Z

Description

"." as field name yields array_index_out_of_bounds_exception, the reason is that we split the field name by . here:

OpenSearch/server/src/main/java/org/opensearch/index/mapper/DocumentParser.java

Line 208 in 49b7cd4

String[] parts = fullFieldPath.split("\\.");

,
, if the field name contains only dot, the split result is an empty array, then yields that exception in this line:

OpenSearch/server/src/main/java/org/opensearch/index/mapper/DocumentParser.java

Line 1045 in 0cde7ba

return objectMapper.getMapper(subfields[subfields.length - 1]);

.

Since . is reserved for object resolution, we can fail the indexing request when the field name contains only dot.

Related Issues

Resolves #14911

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…field name containing only dot Signed-off-by: Gao Binlong <gbinlong@amazon.com>

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

github-actions · 2024-08-06T14:48:43Z

❌ Gradle check result for 94c912e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-06T15:12:44Z

✅ Gradle check result for 778f159: SUCCESS

codecov · 2024-08-06T15:15:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (49b7cd4) to head (2e4fdf5).
Report is 12 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15126      +/-   ##
============================================
- Coverage     71.84%   71.73%   -0.11%     
+ Complexity    62820    62701     -119     
============================================
  Files          5169     5169              
  Lines        294664   294666       +2     
  Branches      42615    42616       +1     
============================================
- Hits         211691   211386     -305     
- Misses        65530    65820     +290     
- Partials      17443    17460      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/src/main/java/org/opensearch/index/mapper/DocumentParser.java

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

github-actions · 2024-08-08T04:46:12Z

✅ Gradle check result for 2e4fdf5: SUCCESS

gaobinlong · 2024-08-09T14:46:07Z

@reta, mind taking a second look at this PR? Thank you!

reta · 2024-08-09T19:01:48Z

Thanks a lot, @gaobinlong !

…field name containing only dot (#15126) * Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Optimize error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 252742b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…documents with field name containing only dot (#15188) * Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot (#15126) * Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Optimize error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 252742b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update 120_field_name.yml Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>

…field name containing only dot (opensearch-project#15126) * Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Optimize error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>

Fix array_index_out_of_bounds_exception when indexing documents with …

94c912e

…field name containing only dot Signed-off-by: Gao Binlong <gbinlong@amazon.com>

gaobinlong requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami and VachaShah as code owners August 6, 2024 14:12

github-actions bot added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing labels Aug 6, 2024

Modify change log

778f159

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

gaobinlong added the backport 2.x Backport to 2.x branch label Aug 6, 2024

jed326 reviewed Aug 8, 2024

View reviewed changes

server/src/main/java/org/opensearch/index/mapper/DocumentParser.java Outdated Show resolved Hide resolved

Optimize error message

2e4fdf5

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

jed326 approved these changes Aug 8, 2024

View reviewed changes

reta approved these changes Aug 9, 2024

View reviewed changes

reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.17.0 labels Aug 9, 2024

reta merged commit 252742b into opensearch-project:main Aug 9, 2024
43 of 44 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 9, 2024

[Backport 2.x] Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15188

Merged

opensearch-ci-bot mentioned this pull request Sep 6, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MasterServiceTests #15809

Open

BrewTestBot mentioned this pull request Sep 18, 2024

opensearch 2.17.0 Homebrew/homebrew-core#191052

Merged

gaobinlong deleted the fieldName branch September 18, 2024 02:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15126

Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15126

gaobinlong commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

codecov bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 8, 2024

gaobinlong commented Aug 9, 2024

reta commented Aug 9, 2024

Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15126

Fix array_index_out_of_bounds_exception when indexing documents with field name containing only dot #15126

Conversation

gaobinlong commented Aug 6, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

codecov bot commented Aug 6, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 8, 2024

gaobinlong commented Aug 9, 2024

reta commented Aug 9, 2024

gaobinlong commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading