Add baseline-cluster-config key to benchmark config #15134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @reta since you have the most context around this. |
reta
reviewed
Aug 6, 2024
Signed-off-by: Rishabh Singh <sngri@amazon.com>
reta
approved these changes
Aug 6, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…ct#15134) Signed-off-by: Rishabh Singh <sngri@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ct#15134) Signed-off-by: Rishabh Singh <sngri@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…ct#15134) Signed-off-by: Rishabh Singh <sngri@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
basline_cluster_configkey to benchmark configs.This will correspond to
user-tags.cluster-configmetadata attached to each metric generated by opensearch-benchmark nightly baseline runs to compare against benchmarks on pull requests. https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/benchmark-pull-request.jenkinsfile#L193-L209This will be used later on finding the latest
test-execution-idof the respective baseline run, run compare with benchmark on pull requesttest-execution-idand publish compare results as well.Related Issues
#14826
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.