Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slice level operation listener methods #15153

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add slice level operation listener methods #15153

merged 1 commit into from
Aug 8, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Aug 7, 2024

Description

Add slice level operation listener to SearchOperationListener plugin interface. See motivation in #15136.

Related Issues

Resolves #15136

Check List

  • Functionality includes testing.
    - [ ] API changes companion pull request created, if applicable.
    - [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Roadmap:Search Project-wide roadmap label Search:Performance labels Aug 7, 2024
@jed326 jed326 added the backport 2.x Backport to 2.x branch label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Gradle check result for 1770e61: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Gradle check result for 9ded024: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Gradle check result for 32a0ea7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326 jed326 marked this pull request as ready for review August 7, 2024 20:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

❌ Gradle check result for f27d3d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Collaborator Author

jed326 commented Aug 8, 2024

https://build.ci.opensearch.org/job/gradle-check/44267/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Gradle check result for f27d3d9: SUCCESS

@jed326
Add slice level operation listener methods
a02230d 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 requested a review from linuxpi as a code owner August 8, 2024 21:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Gradle check result for a02230d: SUCCESS

@jed326 jed326 added the v2.17.0 label Aug 8, 2024
@jed326 jed326 merged commit 978d14e into opensearch-project:main Aug 8, 2024
37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
@github-actions
Add slice level operation listener methods (#15153)
2d53a58 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
(cherry picked from commit 978d14e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 8, 2024
Merged
reta pushed a commit that referenced this pull request Aug 8, 2024
@opensearch-trigger-bot @github-actions
Add slice level operation listener methods (#15153) (#15178)
6fbd079 
(cherry picked from commit 978d14e)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
@jed326 @harshavamsi
Add slice level operation listener methods (opensearch-project#15153)
966a047 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@jed326
Add slice level operation listener methods (opensearch-project#15153)
1bfdfb7 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@jed326 @akolarkunnu
Add slice level operation listener methods (opensearch-project#15153)
0ee56bc 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@sohami sohami sohami approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Roadmap:Search Project-wide roadmap label Search:Performance v2.17.0
Projects
None yet
Milestone
No milestone
4 participants
@jed326 @reta @gaobinlong @sohami