Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Varun Bansal as maintainer #15163

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Add Varun Bansal as maintainer #15163

merged 2 commits into from
Aug 8, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Aug 8, 2024 •
edited
Loading

I have nominated, and maintainers have agreed to add Varun Bansal (@linuxpi ) as a co-maintainer, who kindly accepted.

Varun is an active contributor of OpenSearch project and is the proposer/developer of Offline Background Tasks and has extensively contributed to Remote Store and Remote Cluster State features which has been launched successfully for users, with most of his recent works focused on offline background task , remote cluster state and remote store related areas. Apart from this, he has proactively contributed to identifying critical bugs, resolving them and improving documentations around the same. Varun is also an active member of the OpenSearch Storage bi-weekly triages and has consistently exercised sound judgement in triaging and prioritizing the issues. Varun has led 3 triages and participated in all storage triages.

Varun, has authored 77 pull requests, reviewed 100 pull requests and created 75 issues in the OpenSearch repo last 12 months, with nearly 15 of them being contributed in the last 3 months. Based on his historical contributions, I am reasonably confident, that Varun will be a valuable addition as a maintainer of OpenSearch and will help to contribute to our success going forward.

Notable Proposals

Notable Pull-requests

Notable Code Reviews

Varun has reviewed close to100 pull requests, helping fellow contributors with meaningful feedback to get them merged

  1. Multiple Code Reviews for Remote Cluster state PRs . Some important ones:
    [Remote State] Create service to publish cluster state to remote store #9160
    Upload global cluster state to remote store #10404 and Download functionality of global metadata from remote store #10535
    Split the remote global metadata file to metadata attribute files #12190
  2. Permit based Uploads - [Remote Store] Permit backed futures to prevent timeouts during upload bursts #12159
  3. Remote Routing Table - [Remote Routing Table] Add write flow for remote routing table #13870
  4. Repository Plugin Enhancements - [Remote Store] Add multipart upload integration for translog and segment files #7119 as part of [META] Enhancement of Repository Plugin #6703
  5. Remote Segment Backpressure - Add remote refresh segment pressure service, settings and tracker #7227 and [Remote segments] Add backpressure in write path on segments lag between local and remote store #7459 as part of Back pressure for lagging remote segments upload #6851
  6. Crypto Plugin to Improve encryption and decryption of content - Core crypto library to perform encryption and decryption of source content #8466 as part of [Design Proposal] Client Side Encryption in OpenSearch #6633
  7. Remote Store Repository Registration experience - [Remote Store] Changes to perform repository registration during bootstrap via node attributes. #9105 as part of RFC : Repository Registration for Remote Backed Storage #8623
  8. Storage layer improvements - [Remote Store] Add support to provide separate segment metadata repository #12993 and [Feature Request] [Remote Store] Make metadata store independent of data store #12919

Notable Bug finds

  1. Race condition in remote store leading to replica failure - [Remote Store] Fix replica failing to download segment files from remote store - NoSuchFileException #11455
  2. Deadlock during failover and close - [BUG] Closing an index with ongoing primary failover can lead to deadlocks #11869
  3. Segment upload failure in Remote Store when retries are done post errors in upload flow - [BUG] [Remote Store] Segment upload fails with FileAlreadyExistsException  #7388
  4. Remote Cluster State
    Cluster chaining breakage : [BUG] [Remote State] Cluster chaining can break if there is consecutive node replace and restart #10841
    Cluster UUID Trimming Logic : [Remote State] Update cluster UUID trimming logic for remote state auto restore flow to compare global metadata #10662
    Restoring decommission attributes after Quorum Loss resulting in election loops : [BUG] [Remote State] Auto restoring decommission attributes after QL can lead to election loops #10905
    Remote state auto restore fails : [BUG] [Remote State] Remote state auto restore fails when process restarts before successful master election. #10776

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna
Add Varun Bansal as maintainer
83e0e49 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@gbbafna gbbafna marked this pull request as ready for review August 8, 2024 06:52
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Aug 8, 2024
@gbbafna
Copy link
Collaborator Author

gbbafna commented Aug 8, 2024

Pinging @opensearch-project/admin for help with permissions

@gbbafna
Add to maintainer file as well
103d7d2 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@gbbafna gbbafna merged commit c6189a9 into opensearch-project:main Aug 8, 2024
32 checks passed
@gbbafna gbbafna deleted the varun branch August 8, 2024 08:16
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
@github-actions
Add Varun Bansal as maintainer (#15163)
fd982ee 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit c6189a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 8, 2024
Merged
gbbafna pushed a commit that referenced this pull request Aug 8, 2024
@opensearch-trigger-bot @github-actions
Add Varun Bansal as maintainer (#15163) (#15168)
5ac78d4 
(cherry picked from commit c6189a9)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jed326 jed326 mentioned this pull request Aug 14, 2024
Merged
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
@gbbafna @harshavamsi
Add Varun Bansal as maintainer (opensearch-project#15163)
b2e1f29 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@gbbafna
Add Varun Bansal as maintainer (opensearch-project#15163)
ec7379a 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@gbbafna @akolarkunnu
Add Varun Bansal as maintainer (opensearch-project#15163)
390736f 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gaobinlong gaobinlong Awaiting requested review from gaobinlong gaobinlong is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbbafna @sachinpkale @ashking94